Mismatch between params and docstring in function br.gi.ags3.ags3_to_brgi_db_mapping()

[konnerhorton]

Function: ags3_to_brgi_db_mapping() in br.gi.ags3 (line 128)

Issue: Function includes source as the first parameter, the docstring has ags3_db. The function generates the db from source in the first line but the docstring indicates this should be done outside the function.

What is the expected use case? Should we generate the ags db outside of this function with ags_to_dfs(source), then pass the result to ags3_to_brgi_db_mapping()? Or leave ags3_to_brgi_db_mapping() as is and update the docstring?

I think we can maintain a more flexibility by going with the former (being consistent with the docstring). Though some other changes would need to follow (ags_to_brgi_db_mapping())

[JoostGevaert]

Sry for the late reply.
I think we should change the docstring.
At first I didn't call the ags3_to_dfs(source, encoding) function inside ags3_to_brgi_db_mapping(source, projected_crs, vertical_crs, encoding), but then I found that I ended up having to chain too many functions when I wanted to just read a few AGS files into a Bedrock GI Database.

[JoostGevaert]

Closed with #59