From 1d05c1a842077c730ca9a4ad9685fd919c630ebe Mon Sep 17 00:00:00 2001
From: Day Matchullis <dsm6069@gmail.com>
Date: Fri, 1 Nov 2024 15:09:55 -0600
Subject: [PATCH] use Number.isNaN as it's more robust

---
 src/js/modules/Format/defaults/formatters/money.js   | 4 ++--
 src/js/modules/Format/defaults/formatters/star.js    | 4 ++--
 src/js/modules/Format/defaults/formatters/traffic.js | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/js/modules/Format/defaults/formatters/money.js b/src/js/modules/Format/defaults/formatters/money.js
index 5af2a8460..b30b86a3d 100644
--- a/src/js/modules/Format/defaults/formatters/money.js
+++ b/src/js/modules/Format/defaults/formatters/money.js
@@ -10,7 +10,7 @@ export default function(cell, formatterParams, onRendered){
 	var after = !!formatterParams.symbolAfter;
 	var precision = typeof formatterParams.precision !== "undefined" ? formatterParams.precision : 2;
 
-	if(isNaN(floatVal)){
+	if(Number.isNaN(floatVal)){
 		return this.emptyToSpace(this.sanitizeHTML(cell.getValue()));
 	}
 
@@ -34,4 +34,4 @@ export default function(cell, formatterParams, onRendered){
 	}
 
 	return after ? sign + integer + decimal + symbol : sign + symbol + integer + decimal;
-};
\ No newline at end of file
+};
diff --git a/src/js/modules/Format/defaults/formatters/star.js b/src/js/modules/Format/defaults/formatters/star.js
index 613758165..8b3f7722e 100644
--- a/src/js/modules/Format/defaults/formatters/star.js
+++ b/src/js/modules/Format/defaults/formatters/star.js
@@ -17,7 +17,7 @@ export default function(cell, formatterParams, onRendered){
 	star.setAttribute("xml:space", "preserve");
 	star.style.padding = "0 1px";
 
-	value = value && !isNaN(value) ? parseInt(value) : 0;
+	value = value && !Number.isNaN(value) ? parseInt(value) : 0;
 
 	value = Math.max(0, Math.min(value, maxStars));
 
@@ -35,4 +35,4 @@ export default function(cell, formatterParams, onRendered){
 	element.setAttribute("aria-label", value);
 
 	return stars;
-};
\ No newline at end of file
+};
diff --git a/src/js/modules/Format/defaults/formatters/traffic.js b/src/js/modules/Format/defaults/formatters/traffic.js
index d0f90eaf7..8f6806b0c 100644
--- a/src/js/modules/Format/defaults/formatters/traffic.js
+++ b/src/js/modules/Format/defaults/formatters/traffic.js
@@ -7,7 +7,7 @@ export default function(cell, formatterParams, onRendered){
 	color = "#666666",
 	percent, percentValue;
 
-	if(isNaN(value) || typeof cell.getValue() === "undefined"){
+	if(Number.isNaN(value) || typeof cell.getValue() === "undefined"){
 		return;
 	}
 
@@ -44,4 +44,4 @@ export default function(cell, formatterParams, onRendered){
 	el.style.backgroundColor = color;
 
 	return el;
-};
\ No newline at end of file
+};