Complete code coverage

Author: davidfokkema

src/briefcase/config.py

@@ -161,6 +161,8 @@ def validate_document_type_config(document_type_id, document_type):
             macOS.setdefault("UTTypeConformsTo", ["public.data", "public.content"])
 
         macOS.setdefault("CFBundleTypeRole", "Viewer")
+    else:  # pragma: no-cover-if-is-macos
+        pass
 
 
 VALID_BUNDLE_RE = re.compile(r"[a-zA-Z0-9-]+(\.[a-zA-Z0-9-]+)+$")

src/briefcase/platforms/macOS/utils.py

@@ -10,6 +10,8 @@
 
 from briefcase.exceptions import BriefcaseCommandError
 
+CORETYPES_PATH = "/System/Library/CoreServices/CoreTypes.bundle/Contents/Info.plist"
+
 
 def sha256_file_digest(path: Path) -> str:
     """Compute a sha256 checksum digest of a file.
@@ -289,9 +291,7 @@ def mime_type_to_UTI(mime_type: str) -> str | None:  # pragma: no-cover-if-not-m
         The UTI for the MIME type, or None if the UTI cannot be determined.
     """
     try:
-        plist_data = pathlib.Path(
-            "/System/Library/CoreServices/CoreTypes.bundle/Contents/Info.plist"
-        ).read_bytes()
+        plist_data = pathlib.Path(CORETYPES_PATH).read_bytes()
     except FileNotFoundError:
         # If the file is not found, we assume that the system is not macOS
         # or the file has been moved in recent macOS versions.

tests/config/test_document_type_config.py

@@ -2,6 +2,7 @@
 
 from briefcase.config import validate_document_type_config
 from briefcase.exceptions import BriefcaseConfigError
+from briefcase.platforms.macOS import utils
 
 
 @pytest.fixture
@@ -195,3 +196,9 @@ def test_document_type_macOS_config_with_unknown_mimetype(valid_document):
     valid_document["mime_type"] = "custom/mytype"
     validate_document_type_config("ext", valid_document)
     assert "LSItemContentType" not in valid_document["macOS"].keys()
+
+
+def test_mime_type_to_uti_with_nonexisting_coretypes_file(monkeypatch):
+    """Test that mime_type_to_UTI returns None if the coretypes file doesn't exist."""
+    monkeypatch.setattr(utils, "CORETYPES_PATH", "/does/not/exist")
+    assert utils.mime_type_to_UTI("application/pdf") is None