Fix some Liskov Substitution Principle crimes (#2422)

Author: ambv

changes/2422.misc.rst

@@ -0,0 +1 @@
+Some Liskov substitution issues with typing were resolved.

src/briefcase/commands/convert.py

@@ -27,7 +27,7 @@ class ConvertCommand(NewCommand):
     cmd_line = "briefcase convert"
     command = "convert"
     platform = "all"
-    output_format = None
+    output_format = ""
     description = "Set up an existing project for Briefcase."
 
     @cached_property

src/briefcase/commands/create.py

@@ -631,9 +631,10 @@ def _install_app_requirements(
         app: AppConfig,
         requires: list[str],
         app_packages_path: Path,
+        *,
         progress_message: str = "Installing app requirements...",
         pip_args: list[str] | None = None,
-        pip_kwargs: dict[str, str] | None = None,
+        pip_kwargs: dict[str, dict[str, str | None]] | None = None,
         install_hint: str = "",
     ):
         """Install requirements for the app with pip.

src/briefcase/commands/dev.py

@@ -16,7 +16,7 @@
 class DevCommand(RunAppMixin, BaseCommand):
     cmd_line = "briefcase dev"
     command = "dev"
-    output_format = None
+    output_format = ""
     description = "Run a Briefcase project in the dev environment."
 
     # On macOS CoreFoundation/NSApplication will do its own independent parsing of argc/argv.

src/briefcase/commands/new.py

@@ -76,7 +76,7 @@ class NewCommand(BaseCommand):
     cmd_line = "briefcase new"
     command = "new"
     platform = "all"
-    output_format = None
+    output_format = ""
     description = "Create a new Briefcase project."
 
     def bundle_path(self, app):

src/briefcase/commands/run.py

@@ -249,7 +249,13 @@ def _prepare_app_kwargs(self, app: AppConfig):
         return args
 
     @abstractmethod
-    def run_app(self, app: AppConfig, **options) -> dict | None:
+    def run_app(
+        self,
+        app: AppConfig,
+        *,
+        passthrough: list[str],
+        **options,
+    ) -> dict | None:
         """Start an application.
 
         :param app: The application to start

src/briefcase/commands/upgrade.py

@@ -16,7 +16,7 @@
 class UpgradeCommand(BaseCommand):
     cmd_line = "briefcase upgrade"
     command = "upgrade"
-    output_format = None
+    output_format = ""
     description = "Upgrade Briefcase-managed tools."
 
     @property

src/briefcase/platforms/iOS/__init__.py

@@ -1,3 +1,5 @@
+from __future__ import annotations
+
 from briefcase.integrations.xcode import Xcode
 
 DEFAULT_OUTPUT_FORMAT = "Xcode"
@@ -10,7 +12,7 @@ class iOSMixin:
         "iOS applications require Xcode, which is only available on macOS."
     )
     # 0.3.20 introduced PEP 730-style dynamic libraries.
-    platform_target_version = "0.3.20"
+    platform_target_version: str | None = "0.3.20"
 
     def verify_tools(self):
         Xcode.verify(self.tools, min_version=(13, 0, 0))

src/briefcase/platforms/iOS/xcode.py

@@ -320,6 +320,7 @@ def _install_app_requirements(
         app: AppConfig,
         requires: list[str],
         app_packages_path: Path,
+        **kwargs,
     ):
         # Determine the min iOS version from the VERSIONS file in the support package.
         versions = dict(
@@ -493,10 +494,11 @@ def __init__(self, *args, **kwargs):
     def run_app(
         self,
         app: AppConfig,
+        *,
         passthrough: list[str],
         udid=None,
-        **kwargs,
-    ):
+        **options,
+    ) -> dict | None:
         """Start the application.
 
         :param app: The config object for the app

src/briefcase/platforms/linux/__init__.py

@@ -135,6 +135,7 @@ def _install_app_requirements(
         app: AppConfig,
         requires: list[str],
         app_packages_path: Path,
+        **kwargs,
     ):
         """Install requirements for the app with pip.