Skip to content

Commit 9710bb8

Browse files
committed
Copy ahem font
1 parent 71cbc88 commit 9710bb8

4 files changed

Lines changed: 11 additions & 12 deletions

File tree

colosseum/constants.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -351,15 +351,15 @@ def _available_font_families_mac():
351351
NSFontManager.declare_class_property("sharedFontManager")
352352
NSFontManager.declare_property("availableFontFamilies")
353353
manager = NSFontManager.sharedFontManager
354-
return list(sorted(str(item) for item in manager.availableFontFamilies))
354+
return list(sorted(str(item) for item in manager.availableFontFamilies if item))
355355

356356

357357
def _available_font_families_unix():
358358
"""List available font family names on unix."""
359359
import subprocess
360360
p = subprocess.check_output(['fc-list', ':', 'family'])
361361
fonts = p.decode().split('\n')
362-
return list(sorted(set(fonts)))
362+
return list(sorted(set(item for item in fonts if item)))
363363

364364

365365
AVAILABLE_FONT_FAMILIES = available_font_families()

colosseum/validators.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,9 +124,8 @@ def is_font_family(value=None, generic_family=None, font_families=None):
124124
font_families = font_families or []
125125

126126
def validator(font_value):
127-
print(font_families)
128127
font_value = ' '.join(font_value.strip().split())
129-
values = [v.strip() for v in font_value.split(',') if v.strip()]
128+
values = [v.strip() for v in font_value.split(',')]
130129
checked_values = []
131130
for val in values:
132131
# Remove extra inner spaces

tests/test_fonts.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
'line_height': 'normal',
2323
'font_family': ['sans-serif'],
2424
},
25-
r'bold italic large Palatino, serif': {
25+
r'bold italic large Ahem, serif': {
2626
'font_style': 'italic',
2727
'font_variant': 'normal',
2828
'font_weight': 'bold',
@@ -38,13 +38,13 @@
3838
'line_height': '120%',
3939
'font_family': ['fantasy'],
4040
},
41-
r'x-large/110% "Arial Black",serif': {
41+
r'x-large/110% "DejaVu Sans",serif': {
4242
'font_style': 'normal',
4343
'font_variant': 'normal',
4444
'font_weight': 'normal',
4545
'font_size': 'x-large',
4646
'line_height': '110%',
47-
'font_family': ['"Arial Black"', 'serif'],
47+
'font_family': ['"DejaVu Sans"', 'serif'],
4848
},
4949
}
5050

@@ -58,7 +58,7 @@ def test_parse_font_shorthand(self):
5858

5959
# Test extra spaces
6060
parse_font_property(r' normal normal normal 12px/12px serif ')
61-
parse_font_property(r' normal normal normal 12px/12px " Arial Black ", serif ')
61+
parse_font_property(r' normal normal normal 12px/12px " DejaVu Sans ", serif ')
6262

6363
# Test valid single part
6464
for part in SYSTEM_FONT_KEYWORDS:

tests/test_validators.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,10 @@ def test_number(self):
4444

4545
class FontTests(TestCase):
4646
def test_font_family_name_valid(self):
47-
validator = is_font_family(generic_family=GENERIC_FAMILY_FONTS, font_families=['Arial Black'])
48-
self.assertEqual(validator('"Arial Black", serif'), ['"Arial Black"', 'serif'])
49-
self.assertEqual(validator("'Arial Black',fantasy"), ["'Arial Black'", 'fantasy'])
50-
self.assertEqual(validator(" ' Arial Black ' , fantasy "), ["'Arial Black'", 'fantasy'])
47+
validator = is_font_family(generic_family=GENERIC_FAMILY_FONTS, font_families=['DejaVu Sans'])
48+
self.assertEqual(validator('"DejaVu Sans", serif'), ['"DejaVu Sans"', 'serif'])
49+
self.assertEqual(validator("'DejaVu Sans',fantasy"), ["'DejaVu Sans'", 'fantasy'])
50+
self.assertEqual(validator(" ' DejaVu Sans ' , fantasy "), ["'DejaVu Sans'", 'fantasy'])
5151

5252
def test_font_family_name_invalid(self):
5353
validator = is_font_family(generic_family=GENERIC_FAMILY_FONTS)

0 commit comments

Comments
 (0)