Merge pull request #52 from chrysn-pull-requests/actually-close-socket

transports: Close socket when closing the transport

Author: freakboy3742

CHANGELOG.rst

@@ -11,6 +11,8 @@ Bugfixes
 
 * Corrected the import of ``InvalidStateError`` to fix an error seen on Python 3.8+. (`#56 <https://github.com/beeware/gbulb/issues/56>`__)
 
+* Reverted the fix from #47; that change led to file descriptor leaks. (`#52 <https://github.com/beeware/gbulb/issues/52>`_)
+
 
 0.6.2 (2021-10-24)
 ------------------

src/gbulb/transports.py

@@ -75,7 +75,7 @@ def _force_close_async(self, exc):
             self._protocol.connection_lost(exc)
         finally:
             if self._sock is not None:
-                self._sock.detach()
+                self._sock.close()
                 self._sock = None
             if self._server is not None:
                 self._server._detach()