-
-
Notifications
You must be signed in to change notification settings - Fork 791
Open
Labels
enhancementNew features, or improvements to existing features.New features, or improvements to existing features.good first issueIs this your first time contributing? This could be a good place to start!Is this your first time contributing? This could be a good place to start!
Description
What is the problem or limitation you are having?
Qt backend currently cannot integrate with system themes on Linux.
Describe the solution you'd like
I, with reviews by Russ, has created, integrated into BeeWare, and gotten accepted https://github.com/beeware/system-pyside6 -- a package that solves this problem. The readme and the issue referenced by the first PR on that repo has additional information about why using the system PySide6 runtime is needed.
To fix:
- Add in
https://github.com/beeware/toga/blob/main/qt/pyproject.toml#L62-L68
asystemextra that installssystem-pyside6==0.1.0instead of the regular PySide6 packages. - In https://github.com/beeware/toga/blob/main/docs/en/reference/platforms/linux/qt.md at the bottom, add that toga-qt[system-pyside6] can be used to use the system PySide6 runtime installed through the system packages that provides provides PySide6; explain that since PySide6 bindings are static, they are specific to one version of Qt and thereforre PySide6s needs to be provided through the system package manager to use the system Qt runtime which will integrate with system-provided themes.
- In https://github.com/beeware/toga/blob/main/docs/en/reference/platforms/linux/qt-prerequisites.md, explain that to integrate with system pyside6, installing PySide6 in the system (which auto-installs Qt) is additionally needed; the PySide6 system packages, with minimum distro versions, may be found at the README of https://github.com/beeware/system-pyside6.
Describe alternatives you've considered
There really isn't any after a lot of discussion.
Additional context
No response
Metadata
Metadata
Assignees
Labels
enhancementNew features, or improvements to existing features.New features, or improvements to existing features.good first issueIs this your first time contributing? This could be a good place to start!Is this your first time contributing? This could be a good place to start!