Fixing extra blank line in xml formatting (#1767)

closes #1760

Author: belav

Directory.Build.props

@@ -1,7 +1,7 @@
 <Project>
   <PropertyGroup>
     <TargetFrameworks>net10.0</TargetFrameworks>
-    <LangVersion>12</LangVersion>
+    <LangVersion>14</LangVersion>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
     <!-- this is the warning generators get when they fail to generate a source file this makes sure the error for it failing is obvious -->

Src/CSharpier.Cli/ConsoleLogger.cs

@@ -1,10 +1,13 @@
 using Microsoft.Extensions.Logging;
+#if NET8_0
+using Lock = object;
+#endif
 
 namespace CSharpier.Cli;
 
 internal class ConsoleLogger(IConsole console, LogLevel loggingLevel, LogFormat logFormat) : ILogger
 {
-    private static readonly object ConsoleLock = new();
+    private static readonly Lock ConsoleLock = new();
 
     public virtual void Log<TState>(
         LogLevel logLevel,

Src/CSharpier.Core/Xml/XNodePrinters/Node.cs

@@ -15,34 +15,16 @@ internal static Doc Print(RawNode node, PrintingContext context)
 
             foreach (var childNode in node.Nodes)
             {
-                result.Add(Print(childNode, context), Doc.HardLine);
+                result.Add(
+                    Print(childNode, context),
+                    childNode.NodeType is XmlNodeType.Whitespace ? Doc.Null : Doc.HardLine
+                );
             }
 
             result.Add(Doc.HardLine);
 
             return Doc.Concat(ref result);
         }
-        if (node.NodeType == XmlNodeType.XmlDeclaration)
-        {
-            var version = node.Attributes.FirstOrDefault(o => o.Name == "version")?.Value;
-            var encoding = node.Attributes.FirstOrDefault(o => o.Name == "encoding")?.Value;
-            var standalone = node.Attributes.FirstOrDefault(o => o.Name == "standalone")?.Value;
-
-            var declaration = $"<?xml version=\"{version}\"";
-            if (!string.IsNullOrEmpty(encoding))
-            {
-                declaration += $" encoding=\"{encoding}\"";
-            }
-
-            if (!string.IsNullOrEmpty(standalone))
-            {
-                declaration += $" standalone=\"{standalone}\"";
-            }
-
-            declaration += "?>";
-
-            return declaration;
-        }
 
         if (node.NodeType == XmlNodeType.DocumentType)
         {

Src/CSharpier.Tests/FormattingTests/TestFiles/xml/EmptyLines.test

@@ -1,3 +1,5 @@
+<?xml version="1.0" encoding="utf-8"?>
+
 <Root>
   <Element />
   <Element />