perf: add Concat(IEnumerable) overload and remove ToArray

Author: TimothyMakkison

Src/CSharpier.Core/CSharp/SyntaxPrinter/Modifiers.cs

@@ -80,7 +80,6 @@ PrintingContext context
                             sortedModifiers
                                 .Skip(1)
                                 .Select(o => Token.PrintWithSuffix(o, " ", context))
-                                .ToArray()
                         )
                         : Doc.Null
                 )

Src/CSharpier.Core/CSharp/SyntaxPrinter/SyntaxNodePrinters/ArrayType.cs

@@ -9,7 +9,7 @@ public static Doc Print(ArrayTypeSyntax node, PrintingContext context)
     {
         return Doc.Concat(
             Node.Print(node.ElementType, context),
-            Doc.Concat(node.RankSpecifiers.Select(o => Node.Print(o, context)).ToArray())
+            Doc.Concat(node.RankSpecifiers.Select(o => Node.Print(o, context)))
         );
     }
 }

Src/CSharpier.Core/CSharp/SyntaxPrinter/SyntaxNodePrinters/AttributeList.cs

@@ -89,6 +89,6 @@ node.Parent is CompilationUnitSyntax compilationUnitSyntax
 
         docs.Append(Token.Print(node.CloseBracketToken, context));
 
-        return Doc.Group(docs.AsSpan().ToArray());
+        return Doc.Group(Doc.Concat(ref docs));
     }
 }

Src/CSharpier.Core/CSharp/SyntaxPrinter/SyntaxNodePrinters/BasePropertyDeclaration.cs

@@ -94,7 +94,6 @@ PrintingContext context
                         node.AccessorList.Accessors.Select(o =>
                                 PrintAccessorDeclarationSyntax(o, separator, context)
                             )
-                            .ToArray()
                     ),
                     separator,
                     Token.Print(node.AccessorList.CloseBraceToken, context)

Src/CSharpier.Core/CSharp/SyntaxPrinter/SyntaxNodePrinters/BinaryExpression.cs

@@ -42,9 +42,7 @@ node.Parent is ConditionalExpressionSyntax conditionalExpressionSyntax
                 && conditionalExpressionSyntax.WhenFalse != node
             );
 
-        return shouldNotIndent
-            ? Doc.Group(docs)
-            : Doc.Group(docs[0], Doc.Indent(docs.Skip(1).ToList()));
+        return shouldNotIndent ? Doc.Group(docs) : Doc.Group(docs[0], Doc.Indent(docs.Skip(1)));
     }
 
     // The goal of this is to group operators of the same precedence such that they all break or none of them break

Src/CSharpier.Core/CSharp/SyntaxPrinter/SyntaxNodePrinters/ImplicitArrayCreationExpression.cs

@@ -7,7 +7,7 @@ internal static class ImplicitArrayCreationExpression
 {
     public static Doc Print(ImplicitArrayCreationExpressionSyntax node, PrintingContext context)
     {
-        var commas = node.Commas.Select(o => Token.Print(o, context)).ToArray();
+        var commas = node.Commas.Select(o => Token.Print(o, context));
         return Doc.Group(
             Token.Print(node.NewKeyword, context),
             Token.Print(node.OpenBracketToken, context),

Src/CSharpier.Core/CSharp/SyntaxPrinter/SyntaxNodePrinters/InvocationExpression.cs

@@ -92,11 +92,11 @@ is LiteralExpressionSyntax
         }
 
         var expanded = Doc.Concat(
-            Doc.Concat(groups[0].Select(o => o.Doc).ToArray()),
+            Doc.Concat(groups[0].Select(o => o.Doc)),
             shouldMergeFirstTwoGroups
                 ? Doc.IndentIf(
                     groups.Count > 2 && groups[1].Last().Doc is not Group { Contents: IndentDoc },
-                    Doc.Concat(groups[1].Select(o => o.Doc).ToArray())
+                    Doc.Concat(groups[1].Select(o => o.Doc))
                 )
                 : Doc.Null,
             PrintIndentedGroup(groups.Skip(shouldMergeFirstTwoGroups ? 2 : 1).ToList())

Src/CSharpier.Core/CSharp/SyntaxPrinter/SyntaxNodePrinters/Parameter.cs

@@ -53,6 +53,6 @@ public static Doc Print(ParameterSyntax node, PrintingContext context)
             docs.Append(EqualsValueClause.Print(node.Default, context));
         }
 
-        return hasAttribute ? Doc.Group(docs.AsSpan().ToArray()) : Doc.Concat(ref docs);
+        return hasAttribute ? Doc.Group(Doc.Concat(ref docs)) : Doc.Concat(ref docs);
     }
 }

Src/CSharpier.Core/CSharp/SyntaxPrinter/SyntaxNodePrinters/SwitchSection.cs

@@ -19,10 +19,7 @@ public static Doc Print(SwitchSectionSyntax node, PrintingContext context)
             docs.Append(
                 Doc.Indent(
                     node.Statements.First() is BlockSyntax ? Doc.Null : Doc.HardLine,
-                    Doc.Join(
-                        Doc.HardLine,
-                        node.Statements.Select(o => Node.Print(o, context)).ToArray()
-                    )
+                    Doc.Join(Doc.HardLine, node.Statements.Select(o => Node.Print(o, context)))
                 )
             );
         }

Src/CSharpier.Core/CSharp/SyntaxPrinter/Token.cs

@@ -168,13 +168,14 @@ public static Doc PrintLeadingTrivia(SyntaxToken syntaxToken, PrintingContext co
             || syntaxToken.Parent is CollectionExpressionSyntax
                 && syntaxToken.RawSyntaxKind() == SyntaxKind.CloseBracketToken;
 
+        var leadingTrivia = syntaxToken.LeadingTrivia;
         var printedTrivia = PrivatePrintLeadingTrivia(
-            syntaxToken.LeadingTrivia,
+            leadingTrivia,
             context,
             skipLastHardline: isClosingBrace
         );
 
-        var hasDirective = Enumerable.Any(syntaxToken.LeadingTrivia, o => o.IsDirective);
+        var hasDirective = Enumerable.Any(leadingTrivia, o => o.IsDirective);
 
         if (hasDirective)
         {
@@ -198,9 +199,9 @@ public static Doc PrintLeadingTrivia(SyntaxToken syntaxToken, PrintingContext co
 
         Doc extraNewLines = Doc.Null;
 
-        if (hasDirective || Enumerable.Any(syntaxToken.LeadingTrivia, o => o.IsComment()))
+        if (hasDirective || Enumerable.Any(leadingTrivia, o => o.IsComment()))
         {
-            extraNewLines = ExtraNewLines.Print(syntaxToken.LeadingTrivia);
+            extraNewLines = ExtraNewLines.Print(leadingTrivia);
         }
 
         return printedTrivia != Doc.Null || extraNewLines != Doc.Null