Working on keeping the closing tag of an element clean.

Author: belav

Src/CSharpier.Core/Utilities/ValueListBuilder.cs

@@ -1,6 +1,7 @@
 using System.Buffers;
 using System.Diagnostics;
 using System.Runtime.CompilerServices;
+using System.Text.Json;
 
 namespace CSharpier.Core.Utilities;
 
@@ -176,4 +177,10 @@ private void Grow(int additionalCapacityRequired = 1)
             ArrayPool<T>.Shared.Return(toReturn);
         }
     }
+
+    public override string ToString()
+    {
+        // TODO get this to actually show something useful
+        return JsonSerializer.Serialize(this.ToArray());
+    }
 }

Src/CSharpier.Core/Xml/XNodePrinters/Element.cs

@@ -66,6 +66,15 @@ Doc PrintLineAfterChildren()
             {
                 return Doc.Null;
             }
+
+            if (
+                rawNode.Nodes is [{ NodeType: XmlNodeType.Text }]
+                && rawNode.Nodes[0].Value.Contains('\n')
+            )
+            {
+                return Doc.Null;
+            }
+
             return Doc.SoftLine;
         }
 

Src/CSharpier.Core/Xml/XNodePrinters/Tag.cs

@@ -126,9 +126,31 @@ private static bool NeedsToBorrowParentClosingTagStartMarker(RawNode rawNode)
          *        ^^^
          *     >
          */
+        // TODO #1789 we really want this last condition only if the indentation of the last line of the text value matches
+        // the indentation of the start element. Bleh.
+        /*
+may have to handle one of these vs the second
+<Root>
+  <Element Attribute="TheSign">
+    Life is demanding.
+    </Element>
+</Root>
+<Root>
+  <Element Attribute="TheSign">
+    Life is demanding.
+  </Element>
+</Root>
+there is also this case
+<Root>
+       <Element >
+    Life is demanding.
+         </Element>
+</Root>
+         */
         return rawNode.NextNode is null
             && rawNode.IsTextLike()
-            && rawNode.GetLastDescendant().NodeType is XmlNodeType.Text;
+            && rawNode.GetLastDescendant() is { NodeType: XmlNodeType.Text } textNode
+            && !textNode.Value.Contains('\n');
     }
 
     public static bool NeedsToBorrowParentOpeningTagEndMarker(RawNode rawNode)

Src/CSharpier.Tests/FormattingTests/TestFiles/xml/Attributes.test

@@ -11,4 +11,7 @@
             AND '$(MSBuildProjectName)' != 'System.Net.Http.Formatting.NetCore.Test'
             AND '$(MSBuildProjectName)' != 'System.Net.Http.Formatting.NetStandard.Test' "
   />
+  <Element Attribute="TheSign">
+    Life is demanding.
+  </Element>
 </Root>

Src/CSharpier.Tests/FormattingTests/TestFiles/xml/StrictWhitespace.test

@@ -3,8 +3,7 @@
 
     Because whitespace is strict
     The indentation of the closing element can't change
-      </Element
-  >
+      </Element>
   <Element>
     Shorter Text with indentation that can't change
     </Element>