improvements after Thomas' comments + added th2f of n of events vs time after inj and time withing a beam cycle

Author: casarosa

dqm/analysis/modules/src/DQMHistAnalysisTrackingER.cc

@@ -32,7 +32,7 @@ DQMHistAnalysisTrackingERModule::DQMHistAnalysisTrackingERModule()
 
   setDescription("DQM Analysis Module of the Tracking ER Plots.");
 
-  addParam("onTimeHalfWidth", m_onTimeHalfWidth, "a cluster is on time if within ± onTimeHalfWidth", float(50));
+  addParam("onTimeHalfWidth", m_onTimeHalfWidth, "a cluster is on time if within ± onTimeHalfWidth [ns]", float(m_onTimeHalfWidth));
 
 }
 
@@ -53,34 +53,39 @@ void DQMHistAnalysisTrackingERModule::event()
   //compute fraction of tracks with no PXD hits
 
   TH1* hNoPXDHits = findHist("TrackingERDQM/NoOfHitsInTrack_PXD");
-  if (hNoPXDHits != NULL) {
+  if (hNoPXDHits != nullptr) {
 
     int nTracks = hNoPXDHits->GetEntries();
     int nTracksNoPXD = hNoPXDHits->GetBinContent(1);
 
-    m_monObj->setVariable("tracksNoPXDHit", (double)nTracksNoPXD / nTracks);
+    if (nTracks > 0)
+      m_monObj->setVariable("tracksNoPXDHit", (double)nTracksNoPXD / nTracks);
   }
 
   //fraction of offtime SVD hits
   //considering L3V and L456V clusters (separately)
 
   TH1* hSVDL3VTime = findHist("SVDClsTrk/SVDTRK_ClusterTimeV3");
-  if (hSVDL3VTime != NULL) {
+  if (hSVDL3VTime != nullptr) {
     int all = hSVDL3VTime->GetEntries();
-    int bin_min = hSVDL3VTime->GetXaxis()->FindBin(-m_onTimeHalfWidth);
-    int bin_max = hSVDL3VTime->GetXaxis()->FindBin(+m_onTimeHalfWidth);
-    int offtime = all - hSVDL3VTime->Integral(bin_min, bin_max);
-    double offtimeL3Hits = (double)offtime / all;
-    m_monObj->setVariable("offtimeL3Hits", offtimeL3Hits);
+    if (all > 0) {
+      int bin_min = hSVDL3VTime->GetXaxis()->FindBin(-m_onTimeHalfWidth);
+      int bin_max = hSVDL3VTime->GetXaxis()->FindBin(+m_onTimeHalfWidth);
+      int offtime = all - hSVDL3VTime->Integral(bin_min, bin_max);
+      double offtimeL3Hits = (double)offtime / all;
+      m_monObj->setVariable("offtimeL3Hits", offtimeL3Hits);
+    }
   }
 
   TH1* hSVDL456VTime = findHist("SVDClsTrk/SVDTRK_ClusterTimeV456");
-  if (hSVDL456VTime != NULL) {
+  if (hSVDL456VTime != nullptr) {
     int all = hSVDL456VTime->GetEntries();
-    int bin_min = hSVDL456VTime->GetXaxis()->FindBin(-m_onTimeHalfWidth);
-    int bin_max = hSVDL456VTime->GetXaxis()->FindBin(+m_onTimeHalfWidth);
-    int offtime = all - hSVDL456VTime->Integral(bin_min, bin_max);
-    double offtimeL456Hits = (double)offtime / all;
-    m_monObj->setVariable("offtimeL456Hits", offtimeL456Hits);
+    if (all > 0) {
+      int bin_min = hSVDL456VTime->GetXaxis()->FindBin(-m_onTimeHalfWidth);
+      int bin_max = hSVDL456VTime->GetXaxis()->FindBin(+m_onTimeHalfWidth);
+      int offtime = all - hSVDL456VTime->Integral(bin_min, bin_max);
+      double offtimeL456Hits = (double)offtime / all;
+      m_monObj->setVariable("offtimeL456Hits", offtimeL456Hits);
+    }
   }
 }

tracking/modules/trackingDQM/include/TrackingHLTDQMModule.h

@@ -53,12 +53,18 @@ namespace Belle2 {
      * The histogram records if any flag was set. */
     TH1F* m_trackingErrorFlags = nullptr;
 
-    /** abort rate as a function of time after injection and time within a bam cycle - HER*/
+    /** abort rate as a function of time after injection and time within a beam cycle - HER*/
     TH2F* m_abortVStimeHER = nullptr;
 
-    /** abort rate as a function of time after injection and time within a bam cycle - LER*/
+    /** number of events as a function of time after injection and time within a beam cycle - HER*/
+    TH2F* m_allVStimeHER = nullptr;
+
+    /** abort rate as a function of time after injection and time within a beam cycle - LER*/
     TH2F* m_abortVStimeLER = nullptr;
 
+    /** number of events as a function of time after injection and time within a beam cycle - LER*/
+    TH2F* m_allVStimeLER = nullptr;
+
     /** Beam revolution time in microseconds (approximated).
      *
      * The exact time could be obtained as

tracking/modules/trackingDQM/src/TrackingHLTDQMModule.cc

@@ -103,18 +103,25 @@ void TrackingHLTDQMModule::event()
         // get last injection time
         auto difference = it.GetTimeSinceLastInjection(0);
         // check time overflow, too long ago
-        if (difference != 0x7FFFFFFF)
-          if (m_eventLevelTrackingInfo->hasAnErrorFlag()) {
-            double timeSinceInj = it.GetTimeSinceLastInjection(0) / c_globalClock;
-            double timeInCycle = timeSinceInj - (int)(timeSinceInj / c_revolutionTime) * c_revolutionTime;
+        if (difference != 0x7FFFFFFF) {
+
+          double timeSinceInj = it.GetTimeSinceLastInjection(0) / c_globalClock;
+          double timeInCycle = timeSinceInj - (int)(timeSinceInj / c_revolutionTime) * c_revolutionTime;
 
+          if (it.GetIsHER(0))
+            m_allVStimeHER->Fill(timeSinceInj, timeInCycle);
+          else
+            m_allVStimeLER->Fill(timeSinceInj, timeInCycle);
+
+          if (m_eventLevelTrackingInfo->hasAnErrorFlag()) {
             if (it.GetIsHER(0))
               m_abortVStimeHER->Fill(timeSinceInj, timeInCycle);
             else
               m_abortVStimeLER->Fill(timeSinceInj, timeInCycle);
-          }
-      }
-    }
+          } //has error flag
+        } //time overflow
+      }// loop on RawFTSW
+    } //RawFTSW is valid
   }  else
     m_trackingErrorFlags->Fill(0.0);