25 fix godbolt (#28)

* drive-by improvement to git ignore

* refactor unique_address logic into a single location

* handle the case where config.hpp isn't generated (aka godbolt)

* drive-by update to 3.28 which is needed for modules support

* driveby: update ci to cmake 3.28

* fix trailing whitespace

* revert 3.28 to make ci happy

* attempt to satisfy clang-format lint ci

* restructure the if-else for has_include

Author: JeffGarland

.github/workflows/ci_tests.yml

@@ -41,7 +41,7 @@ jobs:
     - name: Install Ninja
       uses: lukka/get-cmake@latest
       with:
-        cmakeVersion: ~3.25.0
+        cmakeVersion: ~3.28.0
         ninjaVersion: ^1.11.1
     - name: Setup MSVC
       if: startsWith(matrix.platform.os, 'windows')
@@ -104,7 +104,7 @@ jobs:
     - name: Setup build environment
       uses: lukka/get-cmake@latest
       with:
-        cmakeVersion: ~3.25.0
+        cmakeVersion: ~3.28.0
         ninjaVersion: ^1.11.1
     - name: Install Compiler
       id: install-compiler

.gitignore

@@ -1,6 +1,12 @@
 # SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 
 /.cache
-/.vscode
 /compile_commands.json
 /build
+
+# ignore emacs temp files
+*~
+\#*\#
+
+# ignore vscode settings
+.vscode

include/beman/any_view/detail/any_iterator.hpp

@@ -4,9 +4,9 @@
 #define BEMAN_ANY_VIEW_DETAIL_ANY_ITERATOR_HPP
 
 #include <beman/any_view/concepts.hpp>
-#include <beman/any_view/config.hpp>
 #include <beman/any_view/detail/intrusive_small_ptr.hpp>
 #include <beman/any_view/detail/iterator_adaptor.hpp>
+#include <beman/any_view/detail/unique_address.hpp>
 
 namespace beman::any_view::detail {
 

include/beman/any_view/detail/iterator_adaptor.hpp

@@ -3,9 +3,9 @@
 #ifndef BEMAN_ANY_VIEW_DETAIL_ITERATOR_ADAPTOR_HPP
 #define BEMAN_ANY_VIEW_DETAIL_ITERATOR_ADAPTOR_HPP
 
-#include <beman/any_view/config.hpp>
 #include <beman/any_view/detail/concepts.hpp>
 #include <beman/any_view/detail/iterator_interface.hpp>
+#include <beman/any_view/detail/unique_address.hpp>
 #include <beman/any_view/detail/utility.hpp>
 
 #include <compare>

include/beman/any_view/detail/unique_address.hpp

@@ -0,0 +1,21 @@
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+
+#ifndef BEMAN_ANY_VIEW_DETAIL_UNIQUE_ADDRESS_HPP
+#define BEMAN_ANY_VIEW_DETAIL_UNIQUE_ADDRESS_HPP
+
+#if !defined(__has_include)
+#  if __has_include(<beman/any_view/config.hpp>)
+#    include <beman/any_view/config.hpp>
+#  endif
+#else
+// if the config.hpp file does not exist because this is in godbolt
+// or another context where cmake is not run, default to the correct
+// answer.
+#  if (_MSC_VER)
+#    define BEMAN_ANY_VIEW_NO_UNIQUE_ADDRESS() [[msvc::no_unique_address]]
+#  else
+#    define BEMAN_ANY_VIEW_NO_UNIQUE_ADDRESS() [[no_unique_address]]
+#  endif
+#endif
+
+#endif

include/beman/any_view/detail/view_adaptor.hpp

@@ -3,7 +3,7 @@
 #ifndef BEMAN_ANY_VIEW_DETAIL_VIEW_ADAPTOR_HPP
 #define BEMAN_ANY_VIEW_DETAIL_VIEW_ADAPTOR_HPP
 
-#include <beman/any_view/config.hpp>
+#include <beman/any_view/detail/unique_address.hpp>
 #include <beman/any_view/detail/view_interface.hpp>
 
 namespace beman::any_view::detail {