Skip to content

Commit 0800f4d

Browse files
committed
cleanup diff
1 parent 8b6e7f6 commit 0800f4d

File tree

6 files changed

+45
-10
lines changed

6 files changed

+45
-10
lines changed

.codespellignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
11
claus
2+
moint

.github/workflows/ci_tests.yml

Lines changed: 28 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,13 @@ jobs:
3131
strategy:
3232
fail-fast: false
3333
matrix:
34-
platform: [ubuntu-latest]
34+
platform: [ubuntu-24.04]
3535
compiler:
3636
- cpp: g++
3737
c: gcc
3838
- cpp: clang++
3939
c: clang
40-
cpp_version: [17, 20, 23, 26]
40+
cpp_version: [23]
4141
cmake_args:
4242
- description: "Default"
4343
args: ""
@@ -46,16 +46,22 @@ jobs:
4646
- description: "ASan"
4747
args: "-DCMAKE_CXX_FLAGS='-fsanitize=address -fsanitize=undefined'"
4848
include:
49-
# Needs C++ 20 as C++17 selectivly disables ranges and concepts
50-
# related functionalities
51-
- platform: ubuntu-latest
49+
- platform: ubuntu-24.04
5250
compiler:
5351
cpp: g++
5452
c: gcc
55-
cpp_version: 20
53+
cpp_version: 23
5654
cmake_args:
5755
description: "Werror"
5856
args: "-DCMAKE_CXX_FLAGS='-Wall -Wextra -Wpedantic -Werror'"
57+
- platform: ubuntu-24.04
58+
compiler:
59+
cpp: g++
60+
c: gcc
61+
cpp_version: 23
62+
cmake_args:
63+
description: "Dynamic"
64+
cmake_args: "-DBUILD_SHARED_LIBS=on"
5965

6066
name: "Build & Test: ${{ matrix.compiler.c }} ${{ matrix.cpp_version }} ${{ matrix.cmake_args.description }}"
6167
runs-on: ${{ matrix.platform }}
@@ -66,6 +72,22 @@ jobs:
6672
with:
6773
cmakeVersion: "~3.25.0"
6874
ninjaVersion: "^1.11.1"
75+
- name: Install latest compiler
76+
run: |
77+
if [ "${{ matrix.compiler.cpp}}" == "g++" ]; then
78+
# Install gcc-14
79+
sudo apt-get update
80+
sudo apt-get install -y gcc-14 g++-14
81+
82+
sudo rm /usr/bin/gcc
83+
sudo ln -s /usr/bin/gcc-14 /usr/bin/gcc
84+
85+
sudo rm /usr/bin/g++
86+
sudo ln -s /usr/bin/g++-14 /usr/bin/g++
87+
else
88+
# Install llvm
89+
sudo bash -c "$(wget -O - https://apt.llvm.org/llvm.sh)"
90+
fi
6991
- name: Print installed software
7092
run: |
7193
clang++ --version

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ which dynamic memory allocations are undesired.
3131

3232
#include <beman/inplace_vector/inplace_vector.hpp>
3333

34-
using namespace beman::inplace_vector;
34+
using namespace beman;
3535

3636
/**
3737
* Generates fibonacci sequence using inplace_vector.
@@ -56,7 +56,7 @@ template <int Capacity> inplace_vector<int, Capacity> fibonacci_to(int num) {
5656
5757
### Compiler support
5858
59-
Building this repository requires **C++17** or later.
59+
Building this repository requires **C++23** or later.
6060
6161
### Dependencies
6262

examples/fibonacci.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
#include <beman/inplace_vector/inplace_vector.hpp>
66

7-
using namespace beman::inplace_vector;
7+
using namespace beman;
88

99
/**
1010
* Generates fibonacci sequence using inplace_vector.

tests/beman/inplace_vector/CMakeLists.txt

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,3 +9,14 @@ add_executable(beman.inplace_vector.test inplace_vector.test.cpp)
99
target_link_libraries(beman.inplace_vector.test PRIVATE beman.inplace_vector)
1010

1111
add_test(NAME beman.inplace_vector.test COMMAND beman.inplace_vector.test)
12+
13+
# Migrated test from original implementation
14+
add_executable(beman.inplace_vector.ref-test ref_impl.test.cpp)
15+
target_link_libraries(
16+
beman.inplace_vector.ref-test
17+
PRIVATE beman.inplace_vector
18+
)
19+
add_test(
20+
NAME beman.inplace_vector.ref-test
21+
COMMAND beman.inplace_vector.ref-test
22+
)

tests/beman/inplace_vector/inplace_vector.test.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
22
#include <beman/inplace_vector/inplace_vector.hpp>
3+
#include <cassert>
34

4-
using namespace beman::inplace_vector;
5+
using namespace beman;
56

67
template <typename T> constexpr void test() {
78
using vec = inplace_vector<T, 42>;

0 commit comments

Comments
 (0)