Merge pull request #43 from wusatosi/ref-impl

Switch Implementation

Author: wusatosi

.codespellignore

@@ -1 +1,2 @@
 claus
+moint

.github/workflows/ci_tests.yml

@@ -31,13 +31,13 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        platform: [ubuntu-latest]
+        platform: [ubuntu-24.04]
         compiler:
           - cpp: g++
             c: gcc
           - cpp: clang++
             c: clang
-        cpp_version: [17, 20, 23, 26]
+        cpp_version: [23]
         cmake_args:
           - description: "Default"
             args: ""
@@ -46,16 +46,22 @@ jobs:
           - description: "ASan"
             args: "-DCMAKE_CXX_FLAGS='-fsanitize=address -fsanitize=undefined'"
         include:
-          # Needs C++ 20 as C++17 selectivly disables ranges and concepts
-          # related functionalities
-          - platform: ubuntu-latest
+          - platform: ubuntu-24.04
             compiler:
               cpp: g++
               c: gcc
-            cpp_version: 20
+            cpp_version: 23
             cmake_args:
               description: "Werror"
               args: "-DCMAKE_CXX_FLAGS='-Wall -Wextra -Wpedantic -Werror'"
+          - platform: ubuntu-24.04
+            compiler:
+              cpp: g++
+              c: gcc
+            cpp_version: 23
+            cmake_args:
+              description: "Dynamic"
+              cmake_args: "-DBUILD_SHARED_LIBS=on"
 
     name: "Build & Test: ${{ matrix.compiler.c }} ${{ matrix.cpp_version }} ${{ matrix.cmake_args.description }}"
     runs-on: ${{ matrix.platform }}
@@ -66,6 +72,22 @@ jobs:
         with:
           cmakeVersion: "~3.25.0"
           ninjaVersion: "^1.11.1"
+      - name: Install latest compiler
+        run: |
+          if [ "${{ matrix.compiler.cpp}}" == "g++" ]; then
+            # Install gcc-14
+            sudo apt-get update
+            sudo apt-get install -y gcc-14 g++-14
+
+            sudo rm /usr/bin/gcc
+            sudo ln -s /usr/bin/gcc-14 /usr/bin/gcc
+
+            sudo rm /usr/bin/g++
+            sudo ln -s /usr/bin/g++-14 /usr/bin/g++
+          else
+            # Install llvm
+            sudo bash -c "$(wget -O - https://apt.llvm.org/llvm.sh)"
+          fi
       - name: Print installed software
         run: |
           clang++ --version

README.md

@@ -31,7 +31,7 @@ which dynamic memory allocations are undesired.
 
 #include <beman/inplace_vector/inplace_vector.hpp>
 
-using namespace beman::inplace_vector;
+using namespace beman;
 
 /**
  * Generates fibonacci sequence using inplace_vector.
@@ -56,7 +56,7 @@ template <int Capacity> inplace_vector<int, Capacity> fibonacci_to(int num) {
 
 ### Compiler support
 
-Building this repository requires **C++17** or later.
+Building this repository requires **C++23** or later.
 
 ### Dependencies
 

examples/fibonacci.cpp

@@ -4,7 +4,7 @@
 
 #include <beman/inplace_vector/inplace_vector.hpp>
 
-using namespace beman::inplace_vector;
+using namespace beman;
 
 /**
  * Generates fibonacci sequence using inplace_vector.

include/beman/inplace_vector/inplace_vector.hpp

@@ -9,3 +9,14 @@ add_executable(beman.inplace_vector.test inplace_vector.test.cpp)
 target_link_libraries(beman.inplace_vector.test PRIVATE beman.inplace_vector)
 
 add_test(NAME beman.inplace_vector.test COMMAND beman.inplace_vector.test)
+
+# Migrated test from original implementation
+add_executable(beman.inplace_vector.ref-test ref_impl.test.cpp)
+target_link_libraries(
+    beman.inplace_vector.ref-test
+    PRIVATE beman.inplace_vector
+)
+add_test(
+    NAME beman.inplace_vector.ref-test
+    COMMAND beman.inplace_vector.ref-test
+)

tests/beman/inplace_vector/CMakeLists.txt

@@ -1,7 +1,8 @@
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 #include <beman/inplace_vector/inplace_vector.hpp>
+#include <cassert>
 
-using namespace beman::inplace_vector;
+using namespace beman;
 
 template <typename T> constexpr void test() {
   using vec = inplace_vector<T, 42>;