Skip to content

Commit a900dd5

Browse files
committed
Make CI test strict and quote right
1 parent 8f6435b commit a900dd5

File tree

1 file changed

+16
-15
lines changed

1 file changed

+16
-15
lines changed

.github/workflows/ci_tests.yml

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ jobs:
4444
- description: "TSan"
4545
args: "-DCMAKE_CXX_FLAGS=-fsanitize=thread"
4646
- description: "ASan"
47-
args: "-DCMAKE_CXX_FLAGS=-fsanitize=address -fsanitize=undefined"
47+
args: "-DCMAKE_CXX_FLAGS='-fsanitize=address -fsanitize=undefined'"
4848
include:
4949
# Needs C++ 20 as C++17 selectivly disables ranges and concepts
5050
# related functionalities
@@ -55,17 +55,18 @@ jobs:
5555
cpp_version: 20
5656
cmake_args:
5757
description: "Werror"
58-
cmake_args: "-DCMAKE_CXX_FLAGS='-Werror=all -Werror=extra'"
59-
- platform: ubuntu-latest
60-
compiler:
61-
cpp: g++
62-
c: gcc
63-
cpp_version: 20
64-
cmake_args:
65-
description: "Dynamic"
66-
cmake_args: "-DBUILD_SHARED_LIBS=on"
58+
args: "-DCMAKE_CXX_FLAGS='-Wall -Wextra -Wpedantic -Werror'"
59+
# Note: this is a header only project
60+
# - platform: ubuntu-latest
61+
# compiler:
62+
# cpp: g++
63+
# c: gcc
64+
# cpp_version: 20
65+
# cmake_args:
66+
# description: "Dynamic"
67+
# args: "-DBUILD_SHARED_LIBS=ON"
6768

68-
name: "Bulid & Test: ${{ matrix.compiler.c }} ${{ matrix.cpp_version }} ${{ matrix.cmake_args.description }}"
69+
name: "Build & Test: ${{ matrix.compiler.c }} ${{ matrix.cpp_version }} ${{ matrix.cmake_args.description }}"
6970
runs-on: ${{ matrix.platform }}
7071
steps:
7172
- uses: actions/checkout@v4
@@ -74,31 +75,31 @@ jobs:
7475
with:
7576
cmakeVersion: "~3.25.0"
7677
ninjaVersion: "^1.11.1"
77-
- name: Print installed softwares
78+
- name: Print installed software
7879
run: |
7980
clang++ --version
8081
g++ --version
8182
cmake --version
8283
ninja --version
8384
- name: Configure CMake
8485
run: |
85-
cmake -B build -S . "-DCMAKE_CXX_STANDARD=${{ matrix.cpp_version }} ${{ matrix.cmake_args.args }}"
86+
cmake -B build -S . -DCMAKE_CXX_STANDARD=${{ matrix.cpp_version }} ${{ matrix.cmake_args.args }}
8687
env:
8788
CC: ${{ matrix.compiler.c }}
8889
CXX: ${{ matrix.compiler.cpp }}
8990
CMAKE_GENERATOR: "Ninja Multi-Config"
9091
- name: Build Release
9192
run: |
9293
cmake --build build --config Release --verbose
93-
# cmake --build build --config Release --target all_verify_interface_header_sets
94+
# TODO: cmake --build build --config Release --target all_verify_interface_header_sets
9495
cmake --install build --config Release --prefix /tmp/beman.inplace_vector
9596
find /tmp/beman.inplace_vector -type f
9697
- name: Test Release
9798
run: ctest --test-dir build --build-config Release
9899
- name: Build Debug
99100
run: |
100101
cmake --build build --config Debug --verbose
101-
# cmake --build build --config Debug --target all_verify_interface_header_sets
102+
# TODO: cmake --build build --config Debug --target all_verify_interface_header_sets
102103
cmake --install build --config Debug --prefix /tmp/beman.inplace_vector
103104
find /tmp/beman.inplace_vector -type f
104105
- name: Test Debug

0 commit comments

Comments
 (0)