Skip to content

Commit afd9ff9

Browse files
authored
Merge pull request #38 from ClausKlein/feature/make-ci-test-strict
Make CI test strict and quote right
2 parents 8f6435b + d17db7b commit afd9ff9

File tree

1 file changed

+7
-15
lines changed

1 file changed

+7
-15
lines changed

.github/workflows/ci_tests.yml

Lines changed: 7 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ jobs:
4444
- description: "TSan"
4545
args: "-DCMAKE_CXX_FLAGS=-fsanitize=thread"
4646
- description: "ASan"
47-
args: "-DCMAKE_CXX_FLAGS=-fsanitize=address -fsanitize=undefined"
47+
args: "-DCMAKE_CXX_FLAGS='-fsanitize=address -fsanitize=undefined'"
4848
include:
4949
# Needs C++ 20 as C++17 selectivly disables ranges and concepts
5050
# related functionalities
@@ -55,17 +55,9 @@ jobs:
5555
cpp_version: 20
5656
cmake_args:
5757
description: "Werror"
58-
cmake_args: "-DCMAKE_CXX_FLAGS='-Werror=all -Werror=extra'"
59-
- platform: ubuntu-latest
60-
compiler:
61-
cpp: g++
62-
c: gcc
63-
cpp_version: 20
64-
cmake_args:
65-
description: "Dynamic"
66-
cmake_args: "-DBUILD_SHARED_LIBS=on"
58+
args: "-DCMAKE_CXX_FLAGS='-Wall -Wextra -Wpedantic -Werror'"
6759

68-
name: "Bulid & Test: ${{ matrix.compiler.c }} ${{ matrix.cpp_version }} ${{ matrix.cmake_args.description }}"
60+
name: "Build & Test: ${{ matrix.compiler.c }} ${{ matrix.cpp_version }} ${{ matrix.cmake_args.description }}"
6961
runs-on: ${{ matrix.platform }}
7062
steps:
7163
- uses: actions/checkout@v4
@@ -74,31 +66,31 @@ jobs:
7466
with:
7567
cmakeVersion: "~3.25.0"
7668
ninjaVersion: "^1.11.1"
77-
- name: Print installed softwares
69+
- name: Print installed software
7870
run: |
7971
clang++ --version
8072
g++ --version
8173
cmake --version
8274
ninja --version
8375
- name: Configure CMake
8476
run: |
85-
cmake -B build -S . "-DCMAKE_CXX_STANDARD=${{ matrix.cpp_version }} ${{ matrix.cmake_args.args }}"
77+
cmake -B build -S . -DCMAKE_CXX_STANDARD=${{ matrix.cpp_version }} ${{ matrix.cmake_args.args }}
8678
env:
8779
CC: ${{ matrix.compiler.c }}
8880
CXX: ${{ matrix.compiler.cpp }}
8981
CMAKE_GENERATOR: "Ninja Multi-Config"
9082
- name: Build Release
9183
run: |
9284
cmake --build build --config Release --verbose
93-
# cmake --build build --config Release --target all_verify_interface_header_sets
85+
# TODO: cmake --build build --config Release --target all_verify_interface_header_sets
9486
cmake --install build --config Release --prefix /tmp/beman.inplace_vector
9587
find /tmp/beman.inplace_vector -type f
9688
- name: Test Release
9789
run: ctest --test-dir build --build-config Release
9890
- name: Build Debug
9991
run: |
10092
cmake --build build --config Debug --verbose
101-
# cmake --build build --config Debug --target all_verify_interface_header_sets
93+
# TODO: cmake --build build --config Debug --target all_verify_interface_header_sets
10294
cmake --install build --config Debug --prefix /tmp/beman.inplace_vector
10395
find /tmp/beman.inplace_vector -type f
10496
- name: Test Debug

0 commit comments

Comments
 (0)