Support authless pipeline analysis with mcp and copilot agent

Author: benbp

.github/copilot-instructions.md

@@ -1 +1 @@
-- @azure Rule - Use Azure Best Practices: When generating code for Azure, running terminal commands for Azure, or performing operations related to Azure, invoke your `azure_development-get_best_practices` tool if available.
+- @azure Rule - Use Azure Best Practices: When generating code for Azure, running terminal commands for Azure, or performing operations related to Azure, invoke your `azure_development-get_best_practices` tool if available.

.github/workflows/copilot-setup-steps.yml

@@ -14,3 +14,14 @@ jobs:
     steps:
       - name: Checkout code
         uses: actions/checkout@v4
+
+      - uses: actions/setup-dotnet@v4
+        with:
+          dotnet-version: 9.0.x
+
+      - name: Build azsdk cli
+        run: |
+          set -ex
+          dotnet publish -f net8.0 -c Release -r linux-x64 -p:PublishSingleFile=true --self-contained --output ./artifacts/linux-x64 ./tools/azsdk-cli/Azure.Sdk.Tools.Cli/Azure.Sdk.Tools.Cli.csproj
+          cp ./artifacts/linux-x64/azsdk $GITHUB_WORKSPACE/azsdk
+          $GITHUB_WORKSPACE/azsdk --help

tools/azsdk-cli/Azure.Sdk.Tools.Cli/Helpers/LogAnalysisHelper.cs

@@ -1,3 +1,4 @@
+using System.Security.Policy;
 using Azure.Sdk.Tools.Cli.Models;
 
 namespace Azure.Sdk.Tools.Cli.Helpers;
@@ -39,6 +40,9 @@ public class LogAnalysisHelper(ILogger<LogAnalysisHelper> logger) : ILogAnalysis
 {
     private readonly ILogger<LogAnalysisHelper> logger = logger;
 
+    public const int DEFAULT_BEFORE_LINES = 20;
+    public const int DEFAULT_AFTER_LINES = 20;
+
     // Built-in error keywords for robust error detection
     private static readonly HashSet<Keyword> defaultErrorKeywords =
     [
@@ -75,6 +79,12 @@ public class LogAnalysisHelper(ILogger<LogAnalysisHelper> logger) : ILogAnalysis
     ];
 
     public async Task<List<LogEntry>> AnalyzeLogContent(string filePath, List<string>? keywordOverrides, int? beforeLines, int? afterLines)
+    {
+        using var stream = new StreamReader(filePath);
+        return await AnalyzeLogContent(stream, keywordOverrides, beforeLines, afterLines, filePath: filePath);
+    }
+
+    public async Task<List<LogEntry>> AnalyzeLogContent(StreamReader reader, List<string>? keywordOverrides, int? beforeLines, int? afterLines, string url = "", string filePath = "")
     {
         var keywords = defaultErrorKeywords;
         if (keywordOverrides?.Count > 0)
@@ -86,14 +96,13 @@ public async Task<List<LogEntry>> AnalyzeLogContent(string filePath, List<string
             }
         }
 
-        beforeLines ??= 3;
-        afterLines ??= 20;
+        beforeLines ??= DEFAULT_BEFORE_LINES;
+        afterLines ??= DEFAULT_AFTER_LINES;
         var before = new Queue<string>((int)beforeLines);
         var after = new Queue<string>((int)afterLines);
         var maxAfterLines = afterLines ?? 100;
 
         var errors = new List<LogEntry>();
-        using var reader = new StreamReader(filePath);
 
         var lineNumber = 0;
         string? line;
@@ -127,12 +136,20 @@ public async Task<List<LogEntry>> AnalyzeLogContent(string filePath, List<string
                 var fullContext = before.Concat(after).ToList();
                 before.Clear();
                 after.Clear();
-                errors.Add(new LogEntry
+                var entry = new LogEntry
                 {
-                    File = filePath,
                     Line = lineNumber,
                     Message = string.Join(Environment.NewLine, fullContext)
-                });
+                };
+                if (!string.IsNullOrEmpty(url))
+                {
+                    entry.Url = url;
+                }
+                if (!string.IsNullOrEmpty(filePath))
+                {
+                    entry.File = filePath;
+                }
+                errors.Add(entry);
             }
         }
 

tools/azsdk-cli/Azure.Sdk.Tools.Cli/Helpers/TokenUsageHelper.cs

@@ -69,12 +69,12 @@ public void LogCost()
         Console.WriteLine("--------------------------------------------------------------------------------");
     }
 
-    public static TokenUsageHelper operator +(TokenUsageHelper a, TokenUsageHelper b) => new()
+    public static TokenUsageHelper operator +(TokenUsageHelper a, TokenUsageHelper? b) => new()
     {
-        Models = a.Models.Union(b.Models).ToList(),
-        PromptTokens = a.PromptTokens + b.PromptTokens,
-        CompletionTokens = a.CompletionTokens + b.CompletionTokens,
-        InputCost = a.InputCost + b.InputCost,
-        OutputCost = a.OutputCost + b.OutputCost,
+        Models = a.Models.Union(b?.Models ?? []).ToList(),
+        PromptTokens = a.PromptTokens + (b?.PromptTokens ?? 0),
+        CompletionTokens = a.CompletionTokens + (b?.CompletionTokens ?? 0),
+        InputCost = a.InputCost + (b?.InputCost ?? 0),
+        OutputCost = a.OutputCost + (b?.OutputCost ?? 0),
     };
 }

tools/azsdk-cli/Azure.Sdk.Tools.Cli/Models/Responses/LogAnalysisResponse.cs

@@ -37,7 +37,7 @@ public override string ToString()
             output += $"### Suggested Fix:" + Environment.NewLine +
                       $"{SuggestedFix}" + Environment.NewLine + Environment.NewLine +
                       $"### Errors:" + Environment.NewLine +
-                      $"{string.Join(Environment.NewLine+Environment.NewLine, Errors.Select(e => $"--> {e.File}:{e.Line}{Environment.NewLine}{e.Message}"))}" +
+                      $"{string.Join(Environment.NewLine + Environment.NewLine, Errors.Select(e => $"--> {e.File}:{e.Line}{Environment.NewLine}{e.Message}"))}" +
                       Environment.NewLine;
         }
 
@@ -49,7 +49,10 @@ public class LogEntry
 {
     [JsonPropertyName("file")]
     [JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)]
-    public string File { get; set; } = string.Empty;
+    public string File { get; set; }
+    [JsonPropertyName("url")]
+    [JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)]
+    public string Url { get; set; }
     [JsonPropertyName("line")]
     [JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)]
     public int? Line { get; set; }