Support Scala Set with Guice Multibindings

[tsuckow]

Guice expects a java Set for multibindings requiring a second constructor to do the translation. It would be nice if we supported directly injecting a Scala mutable.Set

Have this:

class MyActor( val stuff:MutableSet[MyType] ) {
  @Inject() def this( stuff:java.util.Set[MyType] ) = this( asScalaSet(stuff) )

Want this:

class MyActor @Inject() ( val stuff:MutableSet[MyType] ) {

[benlings]

I don't know if it's possible to do this in a generic way. Guice requires generic types to have all type parameters fully specified.

[tsuckow]

I attended the Guice Hangout yesterday. Their recommendation (after several non-ideal recommendations) was to make our own newSetBinder function that calls the real one under the hood and then injects a provider for the Scala Set.

Hopefully I will have time to look at this the last week in March, but no guarantees.

[tsuckow]

Ok, I got a basic prototype working. Going to work on integrating into this library and making the syntax jive.

[benlings]

Let me know when you think it's ready and I'll look at merging it in. I'll need to read up a bit on how multibindings work. I'm aware of them, but haven't used them myself.

[tsuckow]

Alright, I got them added. Note that I ported to Guice 3.0 and updated sbt. I have the Guice2 branch that has some older code for multibindings, most could be backported I believe. I am not using Guice2 so I didn't fiddle with that.

http://ci.codingwell.net/job/Scala-Guice/

Not sure if you want me to do a pull request. I am new to this work flow on github.

[benlings]

I'm new to it too... I should have some time in the next week to review your branch.

[ijuma]

What is the status of this?