The module removes "fill" attribute when converting to symbol

[dko-slapdash]

A bugreport here:

https://github.com/karify/external-svg-sprite-loader/blob/842c04a092665b724a25c9c4ff36b974808a0821/lib/SvgDocument.js#L170

Due to this explicit whitelist of attributes,

<svg width="16" height="16" viewBox="0 0 16 16" fill="none" ...>

becomes

<symbol id="..." viewBox="0 0 16 16">

I.e. fill="none" is removed and thus the image changes.

Maybe we can just copy all attributes (or blacklist some) instead of whitelisting? Because fill may not be the only one attribute...

[beautyfree]

agree with @dko-slapdash
@bensampaio I can't use this package because of "fill" property not listed and become remove.

My icons with "fill" looks like

and after plugin work it looks like:

[bertms]

@bensampaio
The SvgDocument.js method does not add the fill attribute， Expect to add it in versions 6.0 and 7.0.
// Create the symbol attributes
['class', 'preserveAspectRatio', 'viewBox'].forEach((name) => {
const value = this.getAttribute(name);

        if (value) {
            attrs.push(`${name}="${value}"`);
        }
    });