github: add NFS tests

Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>

Author: bensmrs

.github/workflows/tests.yml

@@ -14,116 +14,6 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  code-tests:
-    name: Code
-    runs-on: ubuntu-24.04
-    strategy:
-      fail-fast: false
-      matrix:
-        go:
-          - oldstable
-          - stable
-          - tip
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v5
-        with:
-          # Differential ShellCheck requires full git history
-          fetch-depth: 0
-
-      - name: Dependency Review
-        uses: actions/dependency-review-action@v4
-        if: github.event_name == 'pull_request'
-
-      - id: ShellCheck
-        name: Differential ShellCheck
-        uses: redhat-plumbers-in-action/differential-shellcheck@v5
-        env:
-          SHELLCHECK_OPTS: --shell sh
-        with:
-          token: ${{ secrets.GITHUB_TOKEN }}
-        if: github.event_name == 'pull_request' && matrix.go == 'stable'
-
-      - name: Upload artifact with ShellCheck defects in SARIF format
-        uses: actions/upload-artifact@v4
-        with:
-          name: Differential ShellCheck SARIF
-          path: ${{ steps.ShellCheck.outputs.sarif }}
-        if: github.event_name == 'pull_request' && matrix.go == 'stable'
-
-      - name: Install Go (${{ matrix.go }})
-        uses: actions/setup-go@v6
-        with:
-          go-version: ${{ matrix.go }}
-        if: matrix.go != 'tip'
-
-      - name: Install Go (stable)
-        uses: actions/setup-go@v6
-        with:
-          go-version: stable
-        if: matrix.go == 'tip'
-
-      - name: Install Go (tip)
-        run: |
-          go install golang.org/dl/gotip@latest
-          gotip download
-          ~/sdk/gotip/bin/go version
-          echo "PATH=$HOME/go/bin:$HOME/sdk/gotip/bin/:$PATH" >> $GITHUB_ENV
-        if: matrix.go == 'tip'
-
-      - name: Install dependencies
-        run: |
-          sudo apt-get update
-          sudo apt-get install --no-install-recommends -y \
-            curl \
-            gettext \
-            git \
-            libacl1-dev \
-            libcap-dev \
-            libdbus-1-dev \
-            libcowsql-dev \
-            liblxc-dev \
-            lxc-templates \
-            libseccomp-dev \
-            libselinux-dev \
-            libsqlite3-dev \
-            libtool \
-            libudev-dev \
-            make \
-            pipx \
-            pkg-config \
-            shellcheck
-
-          # With pipx >= 1.5.0, we could use pipx --global instead.
-          PIPX_HOME=/opt/pipx PIPX_BIN_DIR=/usr/local/bin \
-            pipx install codespell flake8
-
-      - name: Fix repository permissions
-        run: |
-          sudo chown -R runner:docker .
-
-      - name: Check compatible min Go version
-        run: |
-          go mod tidy
-
-      - name: Download go dependencies
-        run: |
-          go mod download
-
-      - name: Run Incus build
-        run: |
-          make
-
-      - name: Run static analysis
-        env:
-          GITHUB_BEFORE: ${{ github.event.before }}
-        run: |
-          make static-analysis
-
-      - name: Unit tests (all)
-        run: |
-          sudo --preserve-env=CGO_CFLAGS,CGO_LDFLAGS,CGO_LDFLAGS_ALLOW,LD_LIBRARY_PATH LD_LIBRARY_PATH=${LD_LIBRARY_PATH} env "PATH=${PATH}" go test ./...
-
   system-tests:
     name: System
     strategy:
@@ -135,57 +25,9 @@ jobs:
           - cluster
           - standalone
         backend:
-          - dir
-          - btrfs
-          - lvm
-          - zfs
-          - ceph
-          - linstor
-          - random
+          - nfs
         os:
           - ubuntu-24.04
-        include:
-          - go: oldstable
-            suite: cluster
-            backend: dir
-            os: ubuntu-24.04
-          - go: oldstable
-            suite: standalone
-            backend: dir
-            os: ubuntu-24.04
-          - go: tip
-            suite: cluster
-            backend: dir
-            os: ubuntu-24.04
-          - go: tip
-            suite: standalone
-            backend: dir
-            os: ubuntu-24.04
-
-          - go: oldstable
-            suite: cluster
-            backend: dir
-            os: ubuntu-24.04-arm
-          - go: oldstable
-            suite: standalone
-            backend: dir
-            os: ubuntu-24.04-arm
-          - go: stable
-            suite: cluster
-            backend: dir
-            os: ubuntu-24.04-arm
-          - go: stable
-            suite: standalone
-            backend: dir
-            os: ubuntu-24.04-arm
-          - go: tip
-            suite: cluster
-            backend: dir
-            os: ubuntu-24.04-arm
-          - go: tip
-            suite: standalone
-            backend: dir
-            os: ubuntu-24.04-arm
     runs-on: ${{ matrix.os }}
 
     steps:
@@ -434,6 +276,17 @@ jobs:
           # Update the runner env.
           echo "INCUS_LINSTOR_CLUSTER=${runner_ip}" >> "$GITHUB_ENV"
 
+      - name: Setup NFS
+        if: ${{ matrix.backend == 'nfs' }}
+        run: |
+          set -x
+          sudo apt-get install --no-install-recommends -y nfs-kernel-server
+          sudo sed -i 's/# debug=0/debug=1/' /etc/nfs.conf
+          echo "/media 10.0.0.0/8(rw,sync,no_subtree_check,no_root_squash,no_all_squash) 100.64.0.0/8(rw,sync,no_subtree_check,no_root_squash,no_all_squash)" | sudo tee /etc/exports
+          sudo exportfs -a
+          sudo systemctl restart nfs-server.service
+          echo "INCUS_NFS_SHARE=$(hostname -I | cut -d' ' -f1):/media" >> "$GITHUB_ENV"
+
       - name: "Ensure offline mode (block image server)"
         run: |
           sudo nft add table inet filter
@@ -457,148 +310,4 @@ jobs:
           chmod +x ~
           echo "root:1000000:1000000000" | sudo tee /etc/subuid /etc/subgid
           cd test
-          sudo --preserve-env=PATH,GOPATH,GITHUB_ACTIONS,INCUS_VERBOSE,INCUS_BACKEND,INCUS_CEPH_CLUSTER,INCUS_CEPH_CEPHFS,INCUS_CEPH_CEPHOBJECT_RADOSGW,INCUS_LINSTOR_LOCAL_SATELLITE,INCUS_LINSTOR_CLUSTER,INCUS_OFFLINE,INCUS_SKIP_TESTS,INCUS_REQUIRED_TESTS, INCUS_BACKEND=${{ matrix.backend }} ./main.sh ${{ matrix.suite }}
-
-  client:
-    name: Client
-    strategy:
-      fail-fast: false
-      matrix:
-        go:
-          - oldstable
-          - stable
-        os:
-          - ubuntu-latest
-          - macos-latest
-          - windows-latest
-    runs-on: ${{ matrix.os }}
-
-    steps:
-      - name: Checkout code
-        uses: actions/checkout@v5
-
-      - name: Install Go
-        uses: actions/setup-go@v6
-        with:
-          go-version: ${{ matrix.go }}
-
-      - name: Create build directory
-        run: |
-            mkdir bin
-
-      - name: Build static incus (x86_64)
-        env:
-          CGO_ENABLED: 0
-          GOARCH: amd64
-        run: |
-          go build -o bin/incus.x86_64 ./cmd/incus
-
-      - name: Build static incus (aarch64)
-        env:
-          CGO_ENABLED: 0
-          GOARCH: arm64
-        run: |
-          go build -o bin/incus.aarch64 ./cmd/incus
-
-      - name: Build static incus-agent (x86_64)
-        if: runner.os == 'Linux' || runner.os == 'Windows'
-        env:
-          CGO_ENABLED: 0
-          GOARCH: amd64
-        run: |
-          go build -o bin/incus-agent.x86_64 ./cmd/incus-agent
-
-      - name: Build static incus-agent (aarch64)
-        if: runner.os == 'Linux' || runner.os == 'Windows'
-        env:
-          CGO_ENABLED: 0
-          GOARCH: arm64
-        run: |
-          go build -o bin/incus-agent.aarch64 ./cmd/incus-agent
-
-      - name: Build static incus-migrate
-        if: runner.os == 'Linux'
-        env:
-          CGO_ENABLED: 0
-        run: |
-          GOARCH=amd64 go build -o bin/incus-migrate.x86_64 ./cmd/incus-migrate
-          GOARCH=arm64 go build -o bin/incus-migrate.aarch64 ./cmd/incus-migrate
-
-      - name: Build static lxd-to-incus
-        if: runner.os == 'Linux'
-        env:
-          CGO_ENABLED: 0
-        run: |
-          GOARCH=amd64 go build -o bin/lxd-to-incus.x86_64 ./cmd/lxd-to-incus
-          GOARCH=arm64 go build -o bin/lxd-to-incus.aarch64 ./cmd/lxd-to-incus
-
-      - name: Unit tests (client)
-        env:
-          CGO_ENABLED: 0
-        run: go test -v ./client/...
-
-      - name: Unit tests (incus)
-        env:
-          CGO_ENABLED: 0
-        run: go test -v ./cmd/incus/...
-
-      - name: Unit tests (shared)
-        env:
-          CGO_ENABLED: 0
-        run: go test -v ./shared/...
-
-      - name: Upload incus client artifacts
-        if: matrix.go == 'stable'
-        uses: actions/upload-artifact@v4
-        continue-on-error: true
-        with:
-          name: ${{ runner.os }}
-          path: bin/
-
-  documentation:
-    name: Documentation
-    runs-on: ubuntu-24.04
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v5
-
-      - name: Install Go
-        uses: actions/setup-go@v6
-        with:
-          go-version: stable
-
-      - name: Install dependencies
-        run: |
-          sudo apt-get install aspell aspell-en
-          sudo snap install mdl
-
-      - name: Run markdown linter
-        run: |
-          make doc-lint
-
-      - name: Run spell checker
-        run: |
-          make doc-spellcheck
-
-      - name: Run inclusive naming checker
-        uses: get-woke/woke-action@v0
-        with:
-          fail-on-error: true
-          woke-args: "*.md **/*.md -c https://github.com/canonical/Inclusive-naming/raw/main/config.yml"
-
-      - name: Run link checker
-        run: |
-          make doc-linkcheck
-
-      - name: Build docs (Sphinx)
-        run: make doc
-
-      - name: Print warnings (Sphinx)
-        run: if [ -s doc/.sphinx/warnings.txt ]; then cat doc/.sphinx/warnings.txt; exit 1; fi
-
-      - name: Upload documentation artifacts
-        if: always()
-        uses: actions/upload-artifact@v4
-        with:
-          name: documentation
-          path: doc/html
+          sudo --preserve-env=PATH,GOPATH,GITHUB_ACTIONS,INCUS_VERBOSE,INCUS_BACKEND,INCUS_CEPH_CLUSTER,INCUS_CEPH_CEPHFS,INCUS_CEPH_CEPHOBJECT_RADOSGW,INCUS_LINSTOR_LOCAL_SATELLITE,INCUS_LINSTOR_CLUSTER,INCUS_NFS_SHARE,INCUS_OFFLINE,INCUS_SKIP_TESTS,INCUS_REQUIRED_TESTS, INCUS_BACKEND=${{ matrix.backend }} ./main.sh ${{ matrix.suite }}