test: Add clustered NFS tests

Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>

Author: bensmrs

test/includes/clustering.sh

@@ -197,6 +197,12 @@ EOF
   config:
     source: incustest-$(basename "${TEST_DIR}" | sed 's/\./__/g')
     linstor.resource_group.place_count: 1
+EOF
+        fi
+        if [ "${driver}" = "nfs" ]; then
+            cat >> "${INCUS_DIR}/preseed.yaml" << EOF
+  config:
+    source: $INCUS_NFS_SHARE/$(basename "${TEST_DIR}")
 EOF
         fi
         cat >> "${INCUS_DIR}/preseed.yaml" << EOF
@@ -276,10 +282,10 @@ cluster:
   cluster_token: ${token}
   member_config:
 EOF
-        # Declare the pool only if the driver is not ceph or linstor, because
+        # Declare the pool only if the driver doesn't manage remote storage, because
         # the pool doesn't need to be created on the joining
         # node (it's shared with the bootstrap one).
-        if [ "${driver}" != "ceph" ] && [ "${driver}" != "linstor" ]; then
+        if [ "${driver}" != "ceph" ] && [ "${driver}" != "linstor" ] && [ "${driver}" != "nfs" ]; then
             cat >> "${INCUS_DIR}/preseed.yaml" << EOF
   - entity: storage-pool
     name: data

test/suites/clustering.sh

@@ -684,6 +684,8 @@ test_clustering_storage() {
         driver_config="source=incustest-$(basename "${TEST_DIR}")-pool1"
     elif [ "${poolDriver}" = "linstor" ]; then
         driver_config="source=incustest-$(basename "${TEST_DIR}" | sed 's/\./__/g')-pool1"
+    elif [ "${poolDriver}" = "nfs" ]; then
+        driver_config="source=$INCUS_NFS_SHARE/$(basename "${TEST_DIR}")"
     fi
 
     # Define storage pools on the two nodes
@@ -749,11 +751,14 @@ test_clustering_storage() {
         # For ceph volume the source field is the name of the underlying ceph pool
         source1="incustest-$(basename "${TEST_DIR}")"
         source2="${source1}"
-    fi
-    if [ "${poolDriver}" = "linstor" ]; then
+    elif [ "${poolDriver}" = "linstor" ]; then
         # For linstor the source field is the name of the underlying linstor resource group
         source1="incustest-$(basename "${TEST_DIR}" | sed 's/\./__/g')"
         source2="${source1}"
+    elif [ "${poolDriver}" = "nfs" ]; then
+        # For nfs the source field is the name of the underlying nfs share
+        source1="$INCUS_NFS_SHARE/$(basename "${TEST_DIR}")"
+        source2="${source1}"
     fi
     INCUS_DIR="${INCUS_ONE_DIR}" incus storage show pool1 --target node1 | grep source | grep -q "${source1}"
     INCUS_DIR="${INCUS_ONE_DIR}" incus storage show pool1 --target node2 | grep source | grep -q "${source2}"
@@ -766,8 +771,8 @@ test_clustering_storage() {
         ! INCUS_DIR="${INCUS_ONE_DIR}" incus storage show pool1 | grep -q rsync.bwlimit || false
     fi
 
-    if [ "${poolDriver}" = "ceph" ] || [ "${poolDriver}" = "linstor" ]; then
-        # Test migration of ceph- and linstor-based containers
+    if [ "${poolDriver}" = "ceph" ] || [ "${poolDriver}" = "linstor" ] || [ "${poolDriver}" = "nfs" ]; then
+        # Test migration of ceph-, linstor-, and nfs-based containers
         INCUS_DIR="${INCUS_TWO_DIR}" ensure_import_testimage
         INCUS_DIR="${INCUS_ONE_DIR}" incus launch --target node2 -s pool1 testimage foo
 
@@ -796,7 +801,7 @@ test_clustering_storage() {
 
     # If the driver has the same per-node storage pool config (e.g. size), make sure it's included in the
     # member_config, and actually added to a joining node so we can validate it.
-    if [ "${poolDriver}" = "zfs" ] || [ "${poolDriver}" = "btrfs" ] || [ "${poolDriver}" = "ceph" ] || [ "${poolDriver}" = "lvm" ] || [ "${poolDriver}" = "linstor" ]; then
+    if [ "${poolDriver}" = "zfs" ] || [ "${poolDriver}" = "btrfs" ] || [ "${poolDriver}" = "ceph" ] || [ "${poolDriver}" = "lvm" ] || [ "${poolDriver}" = "linstor" ] || [ "${poolDriver}" = "nfs" ]; then
         # Spawn a third node
         setup_clustering_netns 3
         INCUS_THREE_DIR=$(mktemp -d -p "${TEST_DIR}" XXX)
@@ -830,12 +835,12 @@ test_clustering_storage() {
         done
 
         # Other storage backends will be finished with the third node, so we can remove it.
-        if [ "${poolDriver}" != "ceph" ] && [ "${poolDriver}" != "linstor" ]; then
+        if [ "${poolDriver}" != "ceph" ] && [ "${poolDriver}" != "linstor" ] && [ "${poolDriver}" != "nfs" ]; then
             INCUS_DIR="${INCUS_ONE_DIR}" incus cluster remove node3 --yes
         fi
     fi
 
-    if [ "${poolDriver}" = "ceph" ] || [ "${poolDriver}" = "linstor" ]; then
+    if [ "${poolDriver}" = "ceph" ] || [ "${poolDriver}" = "linstor" ] || [ "${poolDriver}" = "nfs" ]; then
         # Move the container to node3, renaming it
         INCUS_DIR="${INCUS_TWO_DIR}" incus move foo bar --target node3
         INCUS_DIR="${INCUS_TWO_DIR}" incus info bar | grep -q "Location: node3"
@@ -925,7 +930,7 @@ test_clustering_storage() {
     INCUS_DIR="${INCUS_ONE_DIR}" incus storage delete pool1
     ! INCUS_DIR="${INCUS_ONE_DIR}" incus storage list | grep -q pool1 || false
 
-    if [ "${poolDriver}" != "ceph" ] && [ "${poolDriver}" != "linstor" ]; then
+    if [ "${poolDriver}" != "ceph" ] && [ "${poolDriver}" != "linstor" ] && [ "${poolDriver}" != "nfs" ]; then
         # Create a volume on node1
         INCUS_DIR="${INCUS_ONE_DIR}" incus storage volume create data web
         INCUS_DIR="${INCUS_ONE_DIR}" incus storage volume list data | grep web | grep -q node1