Skip to content

Inject prometheus.Registerer into metrics factory for test isolation

5fe4aab
Select commit
Loading
Failed to load commit list.
Open

chore(metrics): Replace cosmossdk.io/telemetry with prometheus/client_golang #2966

Inject prometheus.Registerer into metrics factory for test isolation
5fe4aab
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 31, 2025 in 0s

64.15% (target 0.00%)

View this Pull Request on Codecov

64.15% (target 0.00%)

Details

Codecov Report

❌ Patch coverage is 82.05374% with 187 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.15%. Comparing base (cc4ec8a) to head (5fe4aab).

Files with missing lines Patch % Lines
observability/metrics/prometheus/prometheus.go 36.06% 78 Missing ⚠️
execution/client/metrics.go 82.65% 30 Missing ⚠️
node-core/components/metrics_factory.go 17.14% 29 Missing ⚠️
execution/engine/metrics.go 84.13% 23 Missing ⚠️
config/config/config.go 0.00% 5 Missing ⚠️
state-transition/core/metrics.go 94.52% 4 Missing ⚠️
beacon/blockchain/blob_fetcher_metrics.go 95.83% 2 Missing ⚠️
beacon/blockchain/deposit.go 0.00% 2 Missing ⚠️
beacon/blockchain/metrics.go 97.22% 2 Missing ⚠️
cmd/beacond/defaults.go 0.00% 2 Missing ⚠️
... and 6 more
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           blobreactor    #2966      +/-   ##
===============================================
+ Coverage        63.24%   64.15%   +0.91%     
===============================================
  Files              367      371       +4     
  Lines            18014    18597     +583     
===============================================
+ Hits             11393    11931     +538     
- Misses            5713     5759      +46     
+ Partials           908      907       -1     
Files with missing lines Coverage Δ
beacon/blockchain/blob_fetcher.go 73.39% <ø> (-0.48%) ⬇️
beacon/blockchain/blob_queue.go 58.87% <100.00%> (ø)
beacon/blockchain/service.go 86.84% <100.00%> (ø)
beacon/validator/metrics.go 100.00% <100.00%> (ø)
beacon/validator/service.go 100.00% <100.00%> (ø)
consensus/cometbft/service/prepare_proposal.go 83.33% <100.00%> (-0.35%) ⬇️
consensus/cometbft/service/process_proposal.go 49.29% <100.00%> (-0.71%) ⬇️
consensus/cometbft/service/service.go 39.89% <100.00%> (ø)
consensus/cometbft/service/state/state.go 51.51% <100.00%> (ø)
da/blob/factory.go 64.28% <100.00%> (ø)
... and 44 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.