Remove TODO comments, delete unused ProblemGanttPlot.jsx file (#168)

* Remove TODO comments

* Delete unused ProblemGanttPlot.jsx file

Author: phrdang

src/backups/email_hash_lookup.py

@@ -39,7 +39,6 @@ def find_emails_by_hashes(input_file, output_file, target_hashes):
         print(f"Error: The file '{input_file}' or '{output_file}' was not found.")
 
 
-# TODO parameterize as CLI
 if __name__ == "__main__":
     target_list = [
         "e3384165",

src/backups/main.py

@@ -237,7 +237,6 @@ def store(
 
     If any arguments are not specified, this command will use the values in the CONFIG .json file.
     """
-    # TODO add prompt when overwriting db or actual files
     config_dict = read_config(config)
 
     if course_endpoint is None:
@@ -298,7 +297,6 @@ def store(
         print(f"Finished storing backups in {database} in {end - start} seconds")
 
 
-# TODO need to rerun lint with new schema for 61a and c88c fa25
 @app.command()
 def lint(
     database: Annotated[
@@ -325,7 +323,6 @@ def lint(
 
     If any arguments are not specified, this command will use the values in the CONFIG .json file.
     """
-    # TODO add prompt when overwriting db or actual files
     config_dict = read_config(config)
 
     if database is None:
@@ -375,7 +372,6 @@ def backup_file_metadata(
 
     If any arguments are not specified, this command will use the values in the CONFIG .json file.
     """
-    # TODO add prompt when overwriting db or actual files
     config_dict = read_config(config)
 
     if database is None:

src/backups/storage.py

@@ -40,7 +40,6 @@
 
 PREFIX = "../../data/private"
 
-# TODO make this programmatically adjustable
 FILENAME_PREFIX = "/Users/rebeccadang/Desktop/Code/ucb/berkeley-cdss/assignment-snapshots/data/private/"
 
 
@@ -79,7 +78,6 @@ def create_backup_and_write_messages(
             continue
 
         if kind not in MESSAGE_KIND_TO_CLASS:
-            # TODO use typer error output formatting
             print(
                 f"OkPy message kind {kind} in backup_id {backup_id} unrecognized, skipping"
             )

src/notebooks/cs_61a_fa25_ants_study.ipynb

@@ -236,21 +236,20 @@
   },
   {
    "cell_type": "code",
-   "execution_count": 12,
+   "execution_count": null,
    "id": "3515e182",
    "metadata": {},
    "outputs": [],
    "source": [
     "print_debug_data = {\n",
-    "    # TODO find out why there is a path that is None\n",
     "    \"backup_id\": [row[0] for row in file_paths if row[3]],\n",
     "    \"student_email\": [row[1] for row in file_paths if row[3]],\n",
     "    \"created\": [row[2] for row in file_paths if row[3]],\n",
     "    \"num_occurrences_print\": [],\n",
     "}\n",
     "\n",
     "for path in [row[3] for row in file_paths]:\n",
-    "    if path:  # TODO find out why there is a path that is None\n",
+    "    if path:\n",
     "        print_debug_data[\"num_occurrences_print\"].append(\n",
     "            count_search_string_in_file(path, \"print\")\n",
     "        )"

src/notebooks/data_c88c_fa25_ants_study.ipynb

@@ -835,21 +835,20 @@
   },
   {
    "cell_type": "code",
-   "execution_count": 14,
+   "execution_count": null,
    "id": "3515e182",
    "metadata": {},
    "outputs": [],
    "source": [
     "print_debug_data = {\n",
-    "    # TODO find out why there is a path that is None\n",
     "    \"backup_id\": [row[0] for row in file_paths if row[3]],\n",
     "    \"student_email\": [row[1] for row in file_paths if row[3]],\n",
     "    \"created\": [row[2] for row in file_paths if row[3]],\n",
     "    \"num_occurrences_print\": [],\n",
     "}\n",
     "\n",
     "for path in [row[3] for row in file_paths]:\n",
-    "    if path:  # TODO find out why there is a path that is None\n",
+    "    if path:\n",
     "        print_debug_data[\"num_occurrences_print\"].append(\n",
     "            count_search_string_in_file(path, \"print\")\n",
     "        )"

src/snapshots-app/app/controllers/api/backup_file_metadata_controller.rb

@@ -29,8 +29,6 @@ def show
         return
       end
 
-      # TODO error if student doesn't have any backups for this assignment and course
-
       assignment_file_names = AssignmentFile.where(assignment_id: assignment_id).map { |af| af.file_name }
       backup_metadata = BackupMetadatum.where(course: course.okpy_endpoint, assignment: assignment.okpy_endpoint, student_email: student.email).order(:created)
       file_contents_locations = backup_metadata.filter_map do |backup|

src/snapshots-app/app/controllers/api/backups_controller.rb

@@ -1,5 +1,3 @@
-# TODO update tests
-
 class Api::BackupsController < ApplicationController
   def show
     course_id = params[:course_id].to_i
@@ -24,8 +22,6 @@ def show
       return
     end
 
-    # TODO error if student doesn't have any backups for this assignment and course
-
     assignment_file_names = AssignmentFile.where(assignment_id: assignment_id).map { |af| af.file_name }
     assignment_problem_names = AssignmentProblem.where(assignment_id: assignment_id).map { |ap| ap.display_name }
     backup_metadata = BackupMetadatum.where(course: course.okpy_endpoint, assignment: assignment.okpy_endpoint, student_email: student.email).order(:created)

src/snapshots-app/app/controllers/api/debugging/autograder_spam_controller.rb

@@ -1,4 +1,3 @@
-# TODO unit tests
 class Api::Debugging::AutograderSpamController < ApplicationController
   def show
     # Validate params
@@ -29,8 +28,6 @@ def show
       return
     end
 
-    # TODO error if student doesn't have any backups for this assignment and course
-
     backups = BackupMetadatum.where(
       course: course.okpy_endpoint,
       assignment: assignment.okpy_endpoint,

src/snapshots-app/app/controllers/api/debugging/print_statements_controller.rb

@@ -1,8 +1,6 @@
-# TODO unit tests
 class Api::Debugging::PrintStatementsController < ApplicationController
   CACHE_TTL = 1.hour
 
-  # TODO: don't hardcode this
   IGNORE_LINES = [
     "print('All bees are vanquished. You win!')",
     "print('The bees reached homebase or the queen ant queen has perished. Please try again :(')",
@@ -12,7 +10,6 @@ class Api::Debugging::PrintStatementsController < ApplicationController
   # Regex for Python print statements: print(...)
   PRINT_REGEX = /^\s*print\s*\(.*\)/
 
-  # TODO deduplicate from FilesController
   def fetch_file_from_local(object_key)
     file_path = Rails.root.join("../../data/private/#{object_key}")
     if File.exist?(file_path)
@@ -65,8 +62,6 @@ def show
       return
     end
 
-    # TODO error if student doesn't have any backups for this assignment and course
-
     backups = BackupMetadatum.where(
       course: course.okpy_endpoint,
       assignment: assignment.okpy_endpoint,
@@ -95,14 +90,12 @@ def show
         problem: problem_names.join(", "),
         timestamp: backup.created,
         passing: is_passing,
-        # TODO don't hardcode this (other assignments may have multiple files)
         files: [ { name: "ants.py", contents: contents, hasPrint: has_print } ],
         has_print: has_print # internal flag for grouping
       }
     end
 
     # Identify the indices of backups that contain prints
-    # TODO investigate why problem name can be empty. perhaps they just ran `python3 ok` without specifying a problem?
     print_indices = all_data.each_index.select { |i| all_data[i][:has_print] and all_data[i][:problem] != "" }
 
     return render json: [] if print_indices.empty?

src/snapshots-app/app/controllers/api/problem_calendar_controller.rb

@@ -23,8 +23,6 @@ def show
       return
     end
 
-    # TODO error if student doesn't have any backups for this assignment and course
-
     calendar_data = BackupMetadatum
       .where(
         course: course.okpy_endpoint,