Skip to content

Commit 2a7e5de

Browse files
turbomamclaude
andcommitted
chore: address low-risk Copilot AI findings (comments and message strings)
Cosmetic, non-behavioral changes from the AI code-quality findings: - metpo.Makefile diff-release: 'ERROR'/'WARN' -> 'Error'/'Warning' in echo messages for consistent capitalization. - metpo-edit.owl: clarify the obsolescence-reason comment that the IAO code assignment is tracked in issue #521. - qc-positive-fixture.ttl: note that metpo:1000000 / metpo:2000000 are intentional fixture-only replacement IRIs, not production terms. Behavioral findings (cross_ontology_search.py, run_sparql_metatest.sh) are intentionally left for separate review. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent cf83775 commit 2a7e5de

3 files changed

Lines changed: 8 additions & 5 deletions

File tree

src/ontology/metpo-edit.owl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ AnnotationAssertion(rdfs:label IAO:0000231 "has obsolescence reason")
6161

6262
AnnotationAssertion(rdfs:label IAO:0100001 "term replaced by")
6363

64-
# Obsolescence reason values (display labels; correct code ASSIGNMENT is tracked in #521)
64+
# Obsolescence reason values (display labels; correct IAO code assignment for these obsolescence reasons is tracked in issue #521)
6565

6666
AnnotationAssertion(rdfs:label IAO:0000226 "placeholder removed")
6767
AnnotationAssertion(rdfs:label <http://purl.obolibrary.org/obo/OMO_0001000> "out of scope")

src/ontology/metpo.Makefile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -92,12 +92,12 @@ diff-sheets:
9292

9393
# Diff current working templates against the last tagged release
9494
diff-release:
95-
@command -v uv >/dev/null 2>&1 || { echo "ERROR: 'uv' is required for diff-release (host-only target)."; exit 1; }
96-
@command -v git >/dev/null 2>&1 || { echo "ERROR: 'git' is required for diff-release."; exit 1; }
97-
@git rev-parse --is-inside-work-tree >/dev/null 2>&1 || { echo "ERROR: diff-release must be run from within a git work tree."; exit 1; }
95+
@command -v uv >/dev/null 2>&1 || { echo "Error: 'uv' is required for diff-release (host-only target)."; exit 1; }
96+
@command -v git >/dev/null 2>&1 || { echo "Error: 'git' is required for diff-release."; exit 1; }
97+
@git rev-parse --is-inside-work-tree >/dev/null 2>&1 || { echo "Error: diff-release must be run from within a git work tree."; exit 1; }
9898
@release_ref=$$(git describe --tags --abbrev=0 2>/dev/null); \
9999
if [ -z "$$release_ref" ]; then \
100-
echo "WARN: No git tags found; falling back to 'main'."; \
100+
echo "Warning: No git tags found; falling back to 'main'."; \
101101
release_ref=main; \
102102
fi; \
103103
cd ../.. && uv run diff-templates -a "$$release_ref" -b HEAD --cell-diffs

tests/sparql_qc/qc-positive-fixture.ttl

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,9 @@ metpo:9999003 a owl:Class ;
5050
rdfs:label "fixture: a label that wrongly embeds http://example.org/foo" .
5151

5252
# -> multiple-replaced_by-violation.sparql : two distinct IAO:0100001 (term replaced by) values
53+
# metpo:1000000 and metpo:2000000 are intentional fixture-only IRIs: they supply
54+
# two distinct replacement targets for this violation case and are not declared
55+
# here, nor expected to exist as production METPO terms.
5356
metpo:9999004 a owl:Class ;
5457
rdfs:label "fixture: two different replacements" ;
5558
IAO:0100001 metpo:1000000 , metpo:2000000 .

0 commit comments

Comments
 (0)