Skip to content

Suggestion: set port: 4445 by default #161

@SebastianBogado

Description

@SebastianBogado

First of all, thanks for the lib. It's been really useful in handling Sauce Connect proxy by sending a few params.

The matter at hand is that since Sauce Connect v4.6.1, Selenium Relay was disabled by default.

  1. Selenium Relay
  • This feature is no longer enabled by default
  • The feature may be enabled on a specified port using the --se-port option

See here Sauce Connect v4.6.1 changelog for more details.

When running tests against a local development server, without the Selenium Relay all the tests fail with the error
ERROR: connect ECONNREFUSED 127.0.0.1:4445

The error itself its easily addressed by setting the port parameter to 4445, as specified in the Advanced usage section

But because the lib always downloads the latest binary by default, and since 05/19 the latest binary doesn't enable the Selenium Relay by default, would you consider explicitly setting the port in your lib?

I think that as long as the port is set by default, allowing users override the config, there would be no harm with users using older SC versions or setting it to different ports, plus you'd be maintaining the contract with users that are using latest SC with default port.

Thanks for reading!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions