chore: update dependencies#2080
Open
Despire wants to merge 23 commits into
Open
Conversation
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughBumps CI action major versions, upgrades Go toolchain to 1.26.x and many Go/Python deps, updates Alpine/base images in Dockerfiles, switches GCP credential construction to explicit service-account type, and adjusts Kubernetes event/validator APIs and image tags. Changes
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
services/testing-framework/Dockerfile (1)
27-43:⚠️ Potential issue | 🟠 MajorRun the final image as a non-root user.
The runtime stage still defaults to
root, which is unnecessary risk for an image that executes tests and talks to the cluster. Please add a dedicatedUSERand ensure the copied binaries remain executable under that account.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@services/testing-framework/Dockerfile` around lines 27 - 43, The image currently runs as root; create a non-root user and switch to it at runtime: add steps after copying the binaries to create a dedicated user/group (e.g., claudie), ensure ownership of the copied binaries (/usr/local/bin/kubectl and /go/services/testing-framework/testing-framework.test) and any working directories is changed to that user, keep the executables bit (the existing chmod on /usr/local/bin/kubectl should remain or be applied before chown), and set USER to that account before ENTRYPOINT so the testing-framework binary and kubectl run as the non-root user; update any WORKDIR ownership as needed so the process can write to it.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@services/testing-framework/Dockerfile`:
- Around line 27-43: The image currently runs as root; create a non-root user
and switch to it at runtime: add steps after copying the binaries to create a
dedicated user/group (e.g., claudie), ensure ownership of the copied binaries
(/usr/local/bin/kubectl and
/go/services/testing-framework/testing-framework.test) and any working
directories is changed to that user, keep the executables bit (the existing
chmod on /usr/local/bin/kubectl should remain or be applied before chown), and
set USER to that account before ENTRYPOINT so the testing-framework binary and
kubectl run as the non-root user; update any WORKDIR ownership as needed so the
process can write to it.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: e05d9441-967c-4a67-b640-47658b26d72d
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (14)
.github/workflows/CI-pipeline.yml.github/workflows/automatic-docs-update.yml.github/workflows/release-docs.yml.github/workflows/release.ymlgo.modrequirements.txtservices/ansibler/Dockerfileservices/autoscaler-adapter/Dockerfileservices/claudie-operator/Dockerfileservices/kube-eleven/Dockerfileservices/kuber/Dockerfileservices/manager/Dockerfileservices/terraformer/Dockerfileservices/testing-framework/Dockerfile
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@services/claudie-operator/pkg/controller/controller.go`:
- Line 68: The Eventf call is passing dynamic text directly (e.g.,
r.Recorder.Eventf(inputManifest, nil, corev1.EventTypeWarning, "SecretNotFound",
"FetchingSecrets", msg)), which treats the last argument as a format string and
can break on % characters; update each Eventf call in this file (including the
shown call and the other sites referenced around buildProvisioningError,
err.Error, and similar uses) to pass dynamic values via format specifiers (e.g.,
use "%s" or "%v" before the dynamic argument) so the message is treated as a
value rather than a format string; search for r.Recorder.Eventf and replace
occurrences like msg, err.Error(), or buildProvisioningError(...).Error() with
"%s", msg or "%v", err accordingly.
In `@services/claudie-operator/pkg/controller/validator.go`:
- Around line 38-41: The generic parameter to admission.WithValidator should be
the concrete Kubernetes type so replace
admission.WithValidator[runtime.Object](...) with
admission.WithValidator[*v1beta.InputManifest](...) to restore type-safe
decoding; update the call site that constructs validator :=
admission.WithValidator[...](...) and ensure InputManifestValidator is still
passed (InputManifestValidator{log, kc}) and that the v1beta package is imported
where needed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 5c9f050a-4801-435c-a2fc-b65744cbab73
📒 Files selected for processing (6)
internal/nodes/arch_resolver.goservices/autoscaler-adapter/node_manager/cache.goservices/claudie-operator/main.goservices/claudie-operator/pkg/controller/controller.goservices/claudie-operator/pkg/controller/controller_types.goservices/claudie-operator/pkg/controller/validator.go
Despire
added
test-set-autoscaling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates from dependabot PRs.
Summary by CodeRabbit