Added default NGINX proxy_temp_path

Author: bert-mccutchen

Gemfile

@@ -5,6 +5,7 @@ source "https://rubygems.org"
 # Specify your gem's dependencies in ruby-nginx.gemspec
 gemspec
 
+gem "debug"
 gem "puma"
 gem "rack"
 gem "rake"

Gemfile.lock

@@ -11,9 +11,18 @@ GEM
   specs:
     ast (2.4.2)
     cgi (0.4.1)
+    date (3.4.1)
+    debug (1.10.0)
+      irb (~> 1.10)
+      reline (>= 0.3.8)
     diff-lcs (1.5.1)
     erb (4.0.4)
       cgi (>= 0.3.3)
+    io-console (0.8.0)
+    irb (1.15.1)
+      pp (>= 0.6.0)
+      rdoc (>= 4.0.0)
+      reline (>= 0.4.2)
     json (2.10.1)
     language_server-protocol (3.17.0.4)
     lint_roller (1.1.0)
@@ -24,13 +33,23 @@ GEM
       racc
     pastel (0.8.0)
       tty-color (~> 0.5)
+    pp (0.6.2)
+      prettyprint
+    prettyprint (0.2.0)
+    psych (5.2.3)
+      date
+      stringio
     puma (6.6.0)
       nio4r (~> 2.0)
     racc (1.8.1)
     rack (3.1.9)
     rainbow (3.1.1)
     rake (13.2.1)
+    rdoc (6.12.0)
+      psych (>= 4.0.0)
     regexp_parser (2.10.0)
+    reline (0.6.0)
+      io-console (~> 0.5)
     rspec (3.13.0)
       rspec-core (~> 3.13.0)
       rspec-expectations (~> 3.13.0)
@@ -72,6 +91,7 @@ GEM
     standard-performance (1.6.0)
       lint_roller (~> 1.1)
       rubocop-performance (~> 1.23.0)
+    stringio (3.1.5)
     thor (1.3.2)
     tty-color (0.6.0)
     tty-command (0.10.1)
@@ -89,6 +109,7 @@ PLATFORMS
   x86_64-linux
 
 DEPENDENCIES
+  debug
   puma
   rack
   rake

lib/ruby/nginx/configuration.rb

@@ -33,6 +33,7 @@ def generate!
         validate!
         apply_dynamic_defaults!
 
+        create_temp_path!
         create_ssl_certs! if options[:ssl]
         create_log_files! if options[:log]
 
@@ -51,6 +52,7 @@ def defaults
 
       def default_paths
         {
+          temp_path: default_path("tmp"),
           ssl_certificate_path: default_path("certs/_#{options[:domain]}.pem"),
           ssl_certificate_key_path: default_path("certs/_#{options[:domain]}-key.pem"),
           access_log_path: default_path("logs/#{options[:domain]}.access.log"),
@@ -92,6 +94,10 @@ def load_template
         raise Ruby::Nginx::AbortError, "Failed to read template.", cause: e
       end
 
+      def create_temp_path!
+        options[:temp_path] = System::SafeFile.mkdir(options[:temp_path])
+      end
+
       def create_ssl_certs!
         System::Mkcert.create!(
           options[:domain],

lib/ruby/nginx/system/safe_file.rb

@@ -7,6 +7,14 @@ module Nginx
     module System
       class SafeFile
         class << self
+          def mkdir(dir_path)
+            safe_path = File.expand_path(dir_path)
+
+            FileUtils.mkdir_p(dir_path)
+
+            safe_path
+          end
+
           def touch(file_path)
             safe_path = File.expand_path(file_path)
 

lib/ruby/nginx/templates/nginx.conf.erb

@@ -54,6 +54,9 @@ server {
   error_log                   <%= options[:error_log_path] %> warn;
   <% end %>
 
+  # Do not use the default proxy_temp_path, this is to avoid directory permissions issues.
+  proxy_temp_path <%= options[:temp_path] %> 1 2;
+
   # reverse proxy
   location @<%= name %> {
     proxy_pass                         http://<%= name %>;

spec/ruby/nginx_add_spec.rb

@@ -28,6 +28,13 @@
     end
   end
 
+  it "creates the NGINX temp path" do
+    retry_expectation(limit: 30, delay: 1) do
+      path = File.expand_path("~/.ruby-nginx/tmp")
+      expect(Dir.exist?(path)).to be_truthy
+    end
+  end
+
   it "creates the SSL certificate" do
     retry_expectation(limit: 30, delay: 1) do
       path = File.expand_path("~/.ruby-nginx/certs/_example.test.pem")