Skip to content

Manycore Origin Hardcoded, Inaccurate Parameter Name #853

@gaozihou

Description

@gaozihou

https://github.com/bespoke-silicon-group/bsg_replicant/blob/main/libraries/bsg_manycore_config_pod.h#L56
https://github.com/bespoke-silicon-group/bsg_replicant/blob/main/libraries/bsg_manycore_config_pod.h#L65

Should obtain origin by calling hb_mc_config_get_origin(cfg) or hb_mc_config_get_origin_vcore(cfg), which is set by machine variables BSG_MACHINE_ORIGIN_COORD_X and BSG_MACHINE_ORIGIN_COORD_Y:
https://github.com/bespoke-silicon-group/bsg_replicant/blob/main/machines/pod_X1Y1_ruche_X16Y8_hbm_one_pseudo_channel/Makefile.machine.include#L113-L115

Also, the following pod_id parameter names are inaccurate, should be pod instead since they are coordinates, not indices
https://github.com/bespoke-silicon-group/bsg_replicant/blob/main/libraries/bsg_manycore_config_pod.h#L73-L129

Metadata

Metadata

Assignees

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions