Skip to content

should only advertise snap/1 in handshake if snapsync-server-enabled #10108

@macfarla

Description

@macfarla

Besu still advertises snap/1 capability in its handshake regardless of whether the snap server is enabled, so peers probe it, get empty responses, classify it as "not a snap server", and never send it snap requests again. The capability advertisement and the actual serving ability are decoupled with no warning.

Arguably Besu shouldn't advertise snap/1 unless --snapsync-server-enabled is set, or at minimum should log a warning at startup that it's advertising snap capability but not serving snap data.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions