Skip to content

Commit 7e807c8

Browse files
authored
Update Setup tab to hide build type/info/firmware when not available (#4459) (#4460)
Update Setup tab to hide build type/info/firmware when not available
1 parent 1a3a949 commit 7e807c8

File tree

1 file changed

+29
-5
lines changed

1 file changed

+29
-5
lines changed

src/js/tabs/setup.js

+29-5
Original file line numberDiff line numberDiff line change
@@ -350,6 +350,20 @@ setup.initialize = function (callback) {
350350
}
351351
};
352352

353+
// Fills in the "Build type" part of the "Firmware info" box
354+
const showBuildType = function () {
355+
build_type_e.html(
356+
FC.CONFIG.buildKey.length === 32
357+
? i18n.getMessage("initialSetupInfoBuildCloud")
358+
: i18n.getMessage("initialSetupInfoBuildLocal"),
359+
);
360+
};
361+
362+
// Hides the "Build type" part of the "Firmware info" box
363+
const hideBuildType = function () {
364+
build_type_e.parent().hide();
365+
};
366+
353367
function showDialogBuildInfo(title, message) {
354368
const dialog = $(".dialogBuildInfo")[0];
355369

@@ -404,6 +418,11 @@ setup.initialize = function (callback) {
404418
}
405419
};
406420

421+
// Hides the "Build info" part of the "Firmware info" box
422+
const hideBuildInfo = function () {
423+
build_info_e.parent().hide();
424+
};
425+
407426
// Fills in the "Firmware" part of the "Firmware info" box
408427
const showBuildFirmware = function () {
409428
const isIspConnected = ispConnected();
@@ -460,19 +479,24 @@ setup.initialize = function (callback) {
460479
}
461480
};
462481

482+
// Hides the "Firmware" part of the "Firmware info" box
483+
const hideBuildFirmware = function () {
484+
build_firmware_e.parent().hide();
485+
};
486+
463487
// Fills in the "Firmware info" box
464488
function showFirmwareInfo() {
465489
msp_api_e.text(FC.CONFIG.apiVersion);
466490
build_date_e.text(FC.CONFIG.buildInfo);
467491

468492
if (semver.gte(FC.CONFIG.apiVersion, API_VERSION_1_45)) {
469-
build_type_e.html(
470-
FC.CONFIG.buildKey.length === 32
471-
? i18n.getMessage("initialSetupInfoBuildCloud")
472-
: i18n.getMessage("initialSetupInfoBuildLocal"),
473-
);
493+
showBuildType();
474494
showBuildInfo();
475495
showBuildFirmware();
496+
} else {
497+
hideBuildType();
498+
hideBuildInfo();
499+
hideBuildFirmware();
476500
}
477501
}
478502

0 commit comments

Comments
 (0)