You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
During review of PR #5273 (save-consolidation onto useSaving.runSave / useReboot), it was noted that useSaving's runSave (and every migrated onError callback across the 10 migrated tabs) only logs failures via console.error. There is no user-facing toast/notification when a save fails.
Rationale
Users currently get no visible feedback if a configuration save fails (e.g. MSP write rejection, timeout, etc.), beyond a browser console error. A uniform "save failed" UX would improve error visibility across all save flows.
Introduce a consistent failure notification (e.g. via gui_log) either as a default behavior inside useSaving's runSave when no onError is provided, or as a shared helper that all onError callbacks invoke, so users see a clear "save failed" message instead of only a console error.
Acceptance criteria
A failed save surfaces a user-visible error message (toast/log) consistently across all tabs using runSave.
Behavior is centralized (not duplicated per-tab) to avoid drift.
Summary
During review of PR #5273 (save-consolidation onto
useSaving.runSave/useReboot), it was noted thatuseSaving'srunSave(and every migratedonErrorcallback across the 10 migrated tabs) only logs failures viaconsole.error. There is no user-facing toast/notification when a save fails.Rationale
Users currently get no visible feedback if a configuration save fails (e.g. MSP write rejection, timeout, etc.), beyond a browser console error. A uniform "save failed" UX would improve error visibility across all save flows.
Affected areas
src/composables/useSaving.js(runSavedefault error handling)runSavein PR refactor(save): consolidate all config saves onto one runSave + saveToEeprom path #5273, including:src/components/tabs/PowerTab.vuesrc/components/tabs/GpsTab.vuesrc/components/tabs/OnboardLoggingTab.vuesrc/components/tabs/ServosTab.vuesrc/components/tabs/AuxiliaryTab.vuesrc/composables/adjustments/useAdjustmentsSave.jssrc/components/tabs/LedStripTab.vuesrc/components/tabs/VtxTab.vuesrc/components/tabs/PidTuningTab.vuesrc/components/tabs/MotorsTab.vueProposed change
Introduce a consistent failure notification (e.g. via
gui_log) either as a default behavior insideuseSaving'srunSavewhen noonErroris provided, or as a shared helper that allonErrorcallbacks invoke, so users see a clear "save failed" message instead of only a console error.Acceptance criteria
runSave.References
onError)