♻️(ingestion-presentation) move files related to archive offer (#532)

* ♻️(ingestion-presentation) move files related to archive offer

* ♻️(ingestion-presentation) move archive usecase API to ingestion

* ♻️(ingestion) remove unuseful auth declaration

Author: AntoineAugusti

src/ingestion/application/use_cases/archive_offer.py

@@ -13,7 +13,7 @@ def __init__(
         self._web_api_key = web_api_key
 
     async def execute(self, reference: str) -> None:
-        url = f"{self._web_base_url}/api/offers/{reference}/archive"
+        url = f"{self._web_base_url}/api/data/offers/{reference}/archive"
         response = await self._client.post(
             url,
             headers={"Authorization": f"Api-Key {self._web_api_key}"},

src/ingestion/tests/integration/test_webhook_archive.py

@@ -20,7 +20,7 @@ async def test_vacancy_status_archived_calls_archive(
 ):
     httpx_mock.add_response(
         method="POST",
-        url=f"{WEB_BASE_URL}/api/offers/{REFERENCE}/archive",
+        url=f"{WEB_BASE_URL}/api/data/offers/{REFERENCE}/archive",
         status_code=200,
     )
     payload = {
@@ -40,7 +40,7 @@ async def test_vacancy_status_archived_calls_archive(
 async def test_vacancy_deleted_calls_archive(talentsoft_client, httpx_mock: HTTPXMock):
     httpx_mock.add_response(
         method="POST",
-        url=f"{WEB_BASE_URL}/api/offers/{REFERENCE}/archive",
+        url=f"{WEB_BASE_URL}/api/data/offers/{REFERENCE}/archive",
         status_code=200,
     )
     payload = {"event_type": "vacancy_deleted", "reference": REFERENCE}

src/ingestion/tests/unit/test_archive_offer_use_case.py

@@ -24,15 +24,15 @@ async def test_execute_posts_to_archive_endpoint(
 ):
     httpx_mock.add_response(
         method="POST",
-        url=f"{WEB_BASE_URL}/api/offers/{REFERENCE}/archive",
+        url=f"{WEB_BASE_URL}/api/data/offers/{REFERENCE}/archive",
         status_code=200,
     )
     await use_case.execute(REFERENCE)
 
     requests = httpx_mock.get_requests()
     assert len(requests) == 1
     assert requests[0].url == httpx.URL(
-        f"{WEB_BASE_URL}/api/offers/{REFERENCE}/archive"
+        f"{WEB_BASE_URL}/api/data/offers/{REFERENCE}/archive"
     )
     assert requests[0].headers["authorization"] == f"Api-Key {WEB_API_KEY}"
 
@@ -43,7 +43,7 @@ async def test_execute_raises_on_error_response(
 ):
     httpx_mock.add_response(
         method="POST",
-        url=f"{WEB_BASE_URL}/api/offers/{REFERENCE}/archive",
+        url=f"{WEB_BASE_URL}/api/data/offers/{REFERENCE}/archive",
         status_code=500,
     )
     with pytest.raises(httpx.HTTPStatusError):

src/web/presentation/api/urls.py

@@ -4,7 +4,7 @@
     TokenRefreshView,
 )
 
-from presentation.api.views import ArchiveOffersView, HueyHealthView, RedocView
+from presentation.api.views import HueyHealthView, RedocView
 
 app_name = "api"
 
@@ -13,9 +13,4 @@
     path("token/refresh/", TokenRefreshView.as_view(), name="token_refresh"),
     path("health/huey/", HueyHealthView.as_view(), name="health_huey"),
     path("schema/redoc/", RedocView.as_view(), name="redoc"),
-    path(
-        "offers/<str:reference>/archive/",
-        ArchiveOffersView.as_view(),
-        name="offers_archive",
-    ),
 ]

src/web/presentation/api/views.py

@@ -1,27 +1,11 @@
 import logging
 
 from django.views.generic import TemplateView
-from drf_spectacular.utils import (
-    PolymorphicProxySerializer,
-    extend_schema,
-    extend_schema_view,
-    inline_serializer,
-)
+from drf_spectacular.utils import extend_schema
 from huey.contrib.djhuey import HUEY
-from rest_framework import serializers as drf_serializers
 from rest_framework import status
-from rest_framework.permissions import IsAuthenticated
 from rest_framework.response import Response
 from rest_framework.views import APIView
-from rest_framework_simplejwt.authentication import JWTAuthentication
-
-from domain.exceptions.offer_errors import OfferDoesNotExist
-from infrastructure.authentication.api_key_authentication import (
-    ApiKeyAuthentication,
-    UserRateThrottleExceptApiKey,
-)
-from infrastructure.di.ingestion.ingestion_factory import create_ingestion_container
-from presentation.ingestion.serializers import TokenErrorSerializer
 
 logger = logging.getLogger(__name__)
 
@@ -35,56 +19,6 @@ def get_context_data(self, **kwargs):
         )
 
 
-class ArchiveOfferSuccessSerializer(drf_serializers.Serializer):
-    status = drf_serializers.CharField()
-
-
-@extend_schema_view(
-    post=extend_schema(
-        request=None,
-        summary="Archiver une offre par référence",
-        description=(
-            "Archive une offre selon sa référence. "
-            "Accepte une authentification JWT ou par clé d'API."
-        ),
-        tags=["offres"],
-        responses={
-            200: ArchiveOfferSuccessSerializer,
-            401: PolymorphicProxySerializer(
-                component_name="ArchiveOffer401Error",
-                serializers=[
-                    TokenErrorSerializer,
-                    inline_serializer(
-                        name="ArchiveOfferUnauthorized",
-                        fields={"detail": drf_serializers.CharField()},
-                    ),
-                ],
-                resource_type_field_name=None,
-            ),
-            404: inline_serializer(
-                name="ArchiveOfferNotFound",
-                fields={"detail": drf_serializers.CharField()},
-            ),
-        },
-    )
-)
-class ArchiveOffersView(APIView):
-    authentication_classes = [JWTAuthentication, ApiKeyAuthentication]
-    permission_classes = [IsAuthenticated]
-    throttle_classes = [UserRateThrottleExceptApiKey]
-
-    serializer_class = ArchiveOfferSuccessSerializer
-
-    def post(self, request, reference: str):
-        container = create_ingestion_container()
-        use_case = container.archive_offer_by_reference_usecase()
-        try:
-            use_case.execute(reference)
-        except OfferDoesNotExist:
-            return Response({"detail": "Not found."}, status=status.HTTP_404_NOT_FOUND)
-        return Response({"status": "ok"}, status=status.HTTP_200_OK)
-
-
 @extend_schema(exclude=True)
 class HueyHealthView(APIView):
     def get(self, request):

src/web/presentation/ingestion/serializers.py

@@ -60,3 +60,7 @@ class ListOffersFiltersSerializer(serializers.Serializer):
 
 class ListOffersErrorSerializer(serializers.Serializer):
     error = serializers.CharField
+
+
+class ArchiveOfferSuccessSerializer(serializers.Serializer):
+    status = serializers.CharField()

src/web/presentation/ingestion/urls.py

@@ -1,10 +1,19 @@
 from django.urls import path
 
-from presentation.ingestion.views import ConcoursUploadView, OffersListView
+from presentation.ingestion.views import (
+    ArchiveOffersView,
+    ConcoursUploadView,
+    OffersListView,
+)
 
 app_name = "ingestion"
 
 urlpatterns = [
     path("concours/upload/", ConcoursUploadView.as_view(), name="concours_upload"),
     path("offers/", OffersListView.as_view(), name="offers_list"),
+    path(
+        "offers/<str:reference>/archive",
+        ArchiveOffersView.as_view(),
+        name="offers_archive",
+    ),
 ]

src/web/presentation/ingestion/views.py

@@ -2,17 +2,29 @@
 
 import polars as pl
 from asgiref.sync import async_to_sync
-from drf_spectacular.utils import PolymorphicProxySerializer, extend_schema
+from drf_spectacular.utils import (
+    PolymorphicProxySerializer,
+    extend_schema,
+    extend_schema_view,
+    inline_serializer,
+)
 from pydantic import ValidationError
+from rest_framework import serializers as drf_serializers
 from rest_framework import status
 from rest_framework.parsers import FormParser, MultiPartParser
 from rest_framework.response import Response
 from rest_framework.views import APIView
+from rest_framework_simplejwt.authentication import JWTAuthentication
 
 from application.ingestion.interfaces.list_offers_input import GetFilteredOffersInput
 from application.ingestion.interfaces.load_documents_input import LoadDocumentsInput
 from application.ingestion.interfaces.load_operation_type import LoadOperationType
 from domain.entities.document import Document, DocumentType
+from domain.exceptions.offer_errors import OfferDoesNotExist
+from infrastructure.authentication.api_key_authentication import (
+    ApiKeyAuthentication,
+    UserRateThrottleExceptApiKey,
+)
 from infrastructure.di.ingestion.ingestion_factory import create_ingestion_container
 from presentation.ingestion.openapi import (
     CONCOURS_UPLOAD_DESCRIPTION,
@@ -23,6 +35,7 @@
 from presentation.ingestion.pagination import IngestionPagination
 from presentation.ingestion.schemas import ConcoursRowSchema
 from presentation.ingestion.serializers import (
+    ArchiveOfferSuccessSerializer,
     ConcoursUploadResponseSerializer,
     FileErrorSerializer,
     ListOffersErrorSerializer,
@@ -353,3 +366,48 @@ def get(self, request):
             return Response(
                 serializer.data, status=status.HTTP_500_INTERNAL_SERVER_ERROR
             )
+
+
+@extend_schema_view(
+    post=extend_schema(
+        request=None,
+        summary="Archiver une offre par référence",
+        description=(
+            "Archive une offre selon sa référence. "
+            "Accepte une authentification JWT ou par clé d'API."
+        ),
+        tags=["offres"],
+        responses={
+            200: ArchiveOfferSuccessSerializer,
+            401: PolymorphicProxySerializer(
+                component_name="ArchiveOffer401Error",
+                serializers=[
+                    TokenErrorSerializer,
+                    inline_serializer(
+                        name="ArchiveOfferUnauthorized",
+                        fields={"detail": drf_serializers.CharField()},
+                    ),
+                ],
+                resource_type_field_name=None,
+            ),
+            404: inline_serializer(
+                name="ArchiveOfferNotFound",
+                fields={"detail": drf_serializers.CharField()},
+            ),
+        },
+    )
+)
+class ArchiveOffersView(APIView):
+    authentication_classes = [JWTAuthentication, ApiKeyAuthentication]
+    throttle_classes = [UserRateThrottleExceptApiKey]
+
+    serializer_class = ArchiveOfferSuccessSerializer
+
+    def post(self, request, reference: str):
+        container = create_ingestion_container()
+        use_case = container.archive_offer_by_reference_usecase()
+        try:
+            use_case.execute(reference)
+        except OfferDoesNotExist:
+            return Response({"detail": "Not found."}, status=status.HTTP_404_NOT_FOUND)
+        return Response({"status": "ok"}, status=status.HTTP_200_OK)

src/web/tests/ingestion/presentation/views/test_archive_offers_view.py

@@ -11,7 +11,7 @@
 
 
 def make_url(reference: str = REFERENCE) -> str:
-    return reverse("api:offers_archive", kwargs={"reference": reference})
+    return reverse("ingestion:offers_archive", kwargs={"reference": reference})
 
 
 @pytest.fixture
@@ -24,7 +24,8 @@ def mock_container(use_case):
     container = MagicMock()
     container.archive_offer_by_reference_usecase.return_value = use_case
     with patch(
-        "presentation.api.views.create_ingestion_container", return_value=container
+        "presentation.ingestion.views.create_ingestion_container",
+        return_value=container,
     ):
         yield container