♻️(tooling-tests) refactor patching container creation in presentation tests (#656)

Author: vincentporte

src/web/tests/candidate/presentation/views/test_cv_results_view.py

@@ -26,6 +26,14 @@ def cv_metadata_pending():
     )
 
 
+@pytest.fixture
+def mock_execute():
+    with patch(
+        "application.candidate.usecases.match_cv_to_opportunities.MatchCVToOpportunitiesUsecase.execute"
+    ) as mock:
+        yield mock
+
+
 def test_cv_results_invalid_uuid_returns_404(client, db):
     response = client.get("/candidate/cv/invalid-uuid/results/")
 
@@ -46,9 +54,6 @@ def test_cv_results_invalid_uuid_returns_404(client, db):
         ),
     ],
 )
-@patch(
-    "application.candidate.usecases.match_cv_to_opportunities.MatchCVToOpportunitiesUsecase.execute"
-)
 def test_cv_results_selects_response_from_status_and_request_type(
     mock_execute,
     client,
@@ -88,9 +93,6 @@ def test_cv_results_selects_response_from_status_and_request_type(
         mock_execute.assert_not_called()
 
 
-@patch(
-    "application.candidate.usecases.match_cv_to_opportunities.MatchCVToOpportunitiesUsecase.execute"
-)
 def test_cv_results_htmx_results_zone_target_returns_results_list_template(
     mock_execute, client, db, cv_metadata_completed
 ):
@@ -110,9 +112,6 @@ def test_cv_results_htmx_results_zone_target_returns_results_list_template(
     assertContains(response, "Poste ciblé")
 
 
-@patch(
-    "application.candidate.usecases.match_cv_to_opportunities.MatchCVToOpportunitiesUsecase.execute"
-)
 def test_cv_results_htmx_poll_pending_to_completed_transition(
     mock_execute, client, db, cv_metadata_pending
 ):
@@ -165,9 +164,6 @@ def test_cv_results_htmx_request_sets_redirect_header(client, db):
     assert response["HX-Redirect"] == reverse("candidate:cv_upload")
 
 
-@patch(
-    "application.candidate.usecases.match_cv_to_opportunities.MatchCVToOpportunitiesUsecase.execute"
-)
 def test_cv_results_htmx_empty_opportunities_shows_no_results(
     mock_execute, client, db, cv_metadata_completed
 ):
@@ -183,9 +179,6 @@ def test_cv_results_htmx_empty_opportunities_shows_no_results(
     assertTemplateUsed(response, "candidate/components/_no_results_content.html")
 
 
-@patch(
-    "application.candidate.usecases.match_cv_to_opportunities.MatchCVToOpportunitiesUsecase.execute"
-)
 def test_cv_results_no_results_includes_tally_iframe(
     mock_execute, client, db, settings, cv_metadata_completed
 ):
@@ -203,9 +196,6 @@ def test_cv_results_no_results_includes_tally_iframe(
     assertContains(response, f"cv_uuid={cv_metadata_completed.id}")
 
 
-@patch(
-    "application.candidate.usecases.match_cv_to_opportunities.MatchCVToOpportunitiesUsecase.execute"
-)
 def test_cv_results_with_results_includes_tally_modal(
     mock_execute, client, db, settings, cv_metadata_completed
 ):

src/web/tests/candidate/presentation/views/test_cv_upload_view.py

@@ -12,6 +12,14 @@
 from tests.utils.pdf_test_utils import create_minimal_valid_pdf
 
 
+@pytest.fixture
+def mock_container():
+    with patch(
+        "presentation.candidate.views.cv_flow.create_candidate_container"
+    ) as mock:
+        yield mock
+
+
 def test_cv_upload_page_loads_correctly(client, db):
     response = client.get(reverse("candidate:cv_upload"))
 
@@ -25,7 +33,6 @@ def test_cv_upload_page_loads_correctly(client, db):
 
 
 @pytest.mark.parametrize("filename", ["cv.pdf", "CV.PDF"])
-@patch("presentation.candidate.views.cv_flow.create_candidate_container")
 def test_cv_upload_valid_pdf_redirects_to_results(mock_container, client, db, filename):
     # Mock the usecases
     mock_uuid = str(uuid4())

src/web/tests/ingestion/presentation/views/test_list_metiers.py

@@ -13,6 +13,12 @@
 URL = reverse("ingestion:metiers_list")
 
 
+@pytest.fixture
+def mock_container():
+    with patch("presentation.ingestion.views.create_ingestion_container") as mock:
+        yield mock
+
+
 def test_unauthenticated_access(api_client):
     response = api_client.get(URL)
     assert response.status_code == status.HTTP_401_UNAUTHORIZED
@@ -32,8 +38,9 @@ def _make_paginated_mock(mock_container, num_metiers, metiers_slice):
     mock_usecase.execute.return_value = mock_page
     mock_container.return_value.list_metiers_usecase.return_value = mock_usecase
 
+    return mock_usecase
+
 
-@patch("presentation.ingestion.views.create_ingestion_container")
 def test_empty_result(mock_container, authenticated_client):
     _make_paginated_mock(mock_container, num_metiers=0, metiers_slice=[])
 
@@ -48,7 +55,6 @@ def test_empty_result(mock_container, authenticated_client):
     }
 
 
-@patch("presentation.ingestion.views.create_ingestion_container")
 def test_call_without_arg(mock_container, authenticated_client):
     metiers = [MetierFactory.create_entity() for _ in range(2)]
 
@@ -77,7 +83,6 @@ def test_call_without_arg(mock_container, authenticated_client):
 
 
 @pytest.mark.parametrize("domain", [None, "TRE"])
-@patch("presentation.ingestion.views.create_ingestion_container")
 def test_call_with_args(mock_container, authenticated_client, domain):
     _make_paginated_mock(mock_container, num_metiers=0, metiers_slice=[])
 
@@ -89,7 +94,6 @@ def test_call_with_args(mock_container, authenticated_client, domain):
     )
 
 
-@patch("presentation.ingestion.views.create_ingestion_container")
 def test_returns_error_500(mock_container, authenticated_client):
     mock_usecase = MagicMock()
     mock_usecase.execute.side_effect = Exception("db error")
@@ -100,7 +104,6 @@ def test_returns_error_500(mock_container, authenticated_client):
 
 
 @patch("presentation.ingestion.views.IngestionPagination.page_size", new=2)
-@patch("presentation.ingestion.views.create_ingestion_container")
 def test_pagination_page_arg(mock_container, authenticated_client):
     num_metiers = 5
     metiers = [MetierFactory.create_entity() for _ in range(num_metiers)]
@@ -135,7 +138,6 @@ def test_pagination_page_arg(mock_container, authenticated_client):
 
 
 @patch("presentation.ingestion.views.IngestionPagination.page_size", new=2)
-@patch("presentation.ingestion.views.create_ingestion_container")
 def test_pagination_out_of_bond(mock_container, authenticated_client):
     num_metiers = 3
     metiers = [MetierFactory.create_entity() for _ in range(num_metiers)]
@@ -159,7 +161,6 @@ def test_pagination_out_of_bond(mock_container, authenticated_client):
     assert data["next"] is None
 
 
-@patch("presentation.ingestion.views.create_ingestion_container")
 def test_invalid_payload(mock_container, authenticated_client):
     _make_paginated_mock(mock_container, num_metiers=0, metiers_slice=[])
 

src/web/tests/ingestion/presentation/views/test_list_offers.py

@@ -15,6 +15,12 @@
 URL = reverse("ingestion:offers_list")
 
 
+@pytest.fixture
+def mock_container():
+    with patch("presentation.ingestion.views.create_ingestion_container") as mock:
+        yield mock
+
+
 def test_unauthenticated_access(api_client):
     response = api_client.get(URL)
     assert response.status_code == status.HTTP_401_UNAUTHORIZED
@@ -34,8 +40,9 @@ def _make_paginated_mock(mock_container, num_offers, offers_slice):
     mock_usecase.execute.return_value = mock_page
     mock_container.return_value.list_offers_usecase.return_value = mock_usecase
 
+    return mock_usecase
+
 
-@patch("presentation.ingestion.views.create_ingestion_container")
 def test_empty_result(mock_container, authenticated_client, list_offers_usecase):
     _make_paginated_mock(mock_container, num_offers=0, offers_slice=[])
 
@@ -50,7 +57,6 @@ def test_empty_result(mock_container, authenticated_client, list_offers_usecase)
     }
 
 
-@patch("presentation.ingestion.views.create_ingestion_container")
 def test_call_without_arg(mock_container, authenticated_client):
     first_offer = OfferFactory.create_entity(
         contract_type=ContractType.TERRITORIAL,
@@ -91,7 +97,6 @@ def test_call_without_arg(mock_container, authenticated_client):
 
 
 @pytest.mark.parametrize("active,external_id_contains", [(True, None), (False, "123")])
-@patch("presentation.ingestion.views.create_ingestion_container")
 def test_call_with_args(
     mock_container, authenticated_client, active, external_id_contains
 ):
@@ -108,7 +113,6 @@ def test_call_with_args(
     )
 
 
-@patch("presentation.ingestion.views.create_ingestion_container")
 def test_returns_error_500(mock_container, authenticated_client):
     mock_usecase = MagicMock()
     mock_usecase.execute.side_effect = Exception("db error")
@@ -119,7 +123,6 @@ def test_returns_error_500(mock_container, authenticated_client):
 
 
 @patch("presentation.ingestion.views.IngestionPagination.page_size", new=2)
-@patch("presentation.ingestion.views.create_ingestion_container")
 def test_pagination_page_arg(mock_container, authenticated_client):
     num_offers = 5
     offers = [OfferFactory.create_entity() for _ in range(num_offers)]
@@ -156,7 +159,6 @@ def test_pagination_page_arg(mock_container, authenticated_client):
 
 
 @patch("presentation.ingestion.views.IngestionPagination.page_size", new=2)
-@patch("presentation.ingestion.views.create_ingestion_container")
 def test_pagination_out_of_bond(mock_container, authenticated_client):
     num_offers = 3
     offers = [OfferFactory.create_entity() for _ in range(num_offers)]

src/web/tests/ingestion/presentation/views/test_list_sources.py

@@ -1,5 +1,6 @@
 from unittest.mock import patch
 
+import pytest
 from django.urls import reverse
 from rest_framework import status
 
@@ -8,6 +9,12 @@
 URL = reverse("ingestion:sources_list")
 
 
+@pytest.fixture
+def mock_container():
+    with patch("presentation.ingestion.views.create_ingestion_container") as mock:
+        yield mock
+
+
 def test_unauthenticated_returns_401(api_client):
     response = api_client.get(URL)
     assert response.status_code == status.HTTP_401_UNAUTHORIZED
@@ -24,7 +31,6 @@ def test_invalid_api_key_returns_401(api_client):
     assert response.status_code == status.HTTP_401_UNAUTHORIZED
 
 
-@patch("presentation.ingestion.views.create_ingestion_container")
 def test_empty_list(mock_container, api_key_client):
     usecase = mock_container.return_value.list_sources_usecase.return_value
     usecase.execute.return_value = []
@@ -35,7 +41,6 @@ def test_empty_list(mock_container, api_key_client):
     assert response.json() == []
 
 
-@patch("presentation.ingestion.views.create_ingestion_container")
 def test_returns_all_sources(mock_container, api_key_client):
     sources = [SourceFactory.create_entity() for _ in range(2)]
     usecase = mock_container.return_value.list_sources_usecase.return_value
@@ -47,7 +52,6 @@ def test_returns_all_sources(mock_container, api_key_client):
     assert len(response.json()) == 2  # noqa: PLR2004
 
 
-@patch("presentation.ingestion.views.create_ingestion_container")
 def test_response_shape(mock_container, api_key_client):
     source = SourceFactory.create_entity()
     usecase = mock_container.return_value.list_sources_usecase.return_value
@@ -66,7 +70,6 @@ def test_response_shape(mock_container, api_key_client):
     }
 
 
-@patch("presentation.ingestion.views.create_ingestion_container")
 def test_returns_500_on_error(mock_container, api_key_client):
     usecase = mock_container.return_value.list_sources_usecase.return_value
     usecase.execute.side_effect = Exception("db error")