Javascript fix issues, unit tests, adding CI

Author: stephenberry

.github/workflows/test.yml

@@ -0,0 +1,32 @@
+name: Tests
+
+on:
+  push:
+    branches: [main]
+  pull_request:
+    branches: [main]
+
+jobs:
+  javascript:
+    name: JavaScript Tests
+    runs-on: ubuntu-latest
+
+    defaults:
+      run:
+        working-directory: javascript
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Setup Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: '20'
+          cache: 'npm'
+          cache-dependency-path: javascript/package-lock.json
+
+      - name: Install dependencies
+        run: npm ci
+
+      - name: Run tests
+        run: npm test

.gitignore

@@ -9,6 +9,13 @@
 !examples/*.json
 !examples/*.beve
 
+# Allow package.json in javascript
+!javascript/package.json
+!javascript/package-lock.json
+
+# JavaScript
+javascript/node_modules/
+
 # Added by cargo
 
 /target

javascript/beve.js

@@ -304,11 +304,12 @@
         }
 
         function read_compressed() {
-            const header = buffer[cursor++];
+            const header = buffer[cursor];
             const config = header & 0b00000011;
 
             switch (config) {
                 case 0:
+                    cursor += 1;
                     return header >> 2;
                 case 1: {
                     const h = new DataView(buffer.buffer, cursor, 2);
@@ -323,8 +324,9 @@
                 case 3: {
                     let val = BigInt(0);
                     for (let i = 0; i < 8; ++i) {
-                        val |= BigInt(buffer[cursor++]) << BigInt(8 * i);
+                        val |= BigInt(buffer[cursor + i]) << BigInt(8 * i);
                     }
+                    cursor += 8;
                     return Number(val >> BigInt(2));
                 }
                 default:
@@ -528,8 +530,11 @@
         } else if (typeof value === 'string') {
             let header = 2;
             writer.append_uint8(header);
-            writeCompressed(writer, value.length);
-            writer.append(value);
+            const bytes = new TextEncoder().encode(value);
+            writeCompressed(writer, bytes.length);
+            writer.ensureCapacity(bytes.length);
+            writer.buffer.set(bytes, writer.offset);
+            writer.offset += bytes.length;
         } else if (Array.isArray(value)) {
             let header = 5;
             writer.append_uint8(header);
@@ -546,8 +551,11 @@
             writer.append_uint8(header);
             writeCompressed(writer, Object.keys(value).length);
             for (const key in value) {
-                writeCompressed(writer, key.length);
-                writer.append(key);
+                const keyBytes = new TextEncoder().encode(key);
+                writeCompressed(writer, keyBytes.length);
+                writer.ensureCapacity(keyBytes.length);
+                writer.buffer.set(keyBytes, writer.offset);
+                writer.offset += keyBytes.length;
                 write_value(writer, value[key]);
             }
         } else {