WIP: continue work on new setup-shell experience (part 3)

had to split allow/disallow and login, as the flow was too confusing with them as one

now actions are: install/uninstall, configure/deconfigure, allow/disallow, login

implemented the arg handling

fixed duplication and detection and exclusions etc for basenames and paths

also innovated with ksh and dash config loading, they can now be toggled independently

need to apply configuration saving now, setup-util-$shell configuration/deconfiguration, etc

also fix linting issues

Author: balupton

README.md

@@ -240,6 +240,7 @@ For each shell that you configured during the Dorothy installation (can be recon
     - [Nu](https://www.nushell.sh) loads our [`init.nu`](https://github.com/bevry/dorothy/blob/master/init.nu) script
     - [Xonsh](https://xon.sh) loads our [`init.xsh`](https://github.com/bevry/dorothy/blob/master/init.xsh) script
     - POSIX shells ([Bash](<https://en.wikipedia.org/wiki/Bash_(Unix_shell)>), [Zsh](https://en.wikipedia.org/wiki/Z_shell), [Dash](https://wiki.archlinux.org/title/Dash), [KSH](https://en.wikipedia.org/wiki/KornShell), etc) load our [`init.sh`](https://github.com/bevry/dorothy/blob/master/init.sh) script
+        - KSH and Dash first load their respective `init.ksh` and `init.dash` scripts before loading `init.sh`. This is because KSH, Dash, and Bash all share the same `.profile` configuration file, so different initialization scripts allow us to configure each of them independently.
 
 1.  The initialization script will:
 

commands/debug-bash

@@ -101,7 +101,7 @@ function debug_bash() (
 	option_cmd[0]="$(type -P "$cmd_first")"
 
 	# resolve bash path
-	local cmd=() exit_status=0
+	local cmd=() __exit_status=0
 	if [[ ${#option_bash_binaries[@]} -ne 0 ]]; then
 		local bash_input bash_path bash_binary bash_version
 		for bash_input in "${option_bash_binaries[@]}"; do
@@ -112,14 +112,14 @@ function debug_bash() (
 			bash_binary="$(type -P "$bash_input" || :)"
 			if [[ -z $bash_binary ]]; then
 				echo-style --error="The bash binary [$bash_input] does not exist."
-				exit_status=2 # ENOENT 2 No such file or directory
+				__exit_status=2 # ENOENT 2 No such file or directory
 				continue
 			fi
 			bash_version="$("$bash_binary" -c 'IFS=. read -r BASH_VERSION_MAJOR BASH_VERSION_MINOR BASH_VERSION_PATCH <<<"${BASH_VERSION%%(*}"; printf '%s' "${BASH_VERSION_MAJOR}.${BASH_VERSION_MINOR}.${BASH_VERSION_PATCH}"')"
 			# check bash version
 			if [[ $bash_version == '4.1'* || $bash_version == '3.1'* || $bash_version == '3.0'* || $bash_version == '2.'* || $bash_version == '1.'* || $bash_version == '0.'* ]]; then
 				echo-style --error="The bash binary [$bash_input] is version [$bash_version], which is not supported."
-				exit_status=75 # EPROGMISMATCH 75 Program version wrong
+				__exit_status=75 # EPROGMISMATCH 75 Program version wrong
 				continue
 			fi
 			bash_path="$(fs-temp --directory='debug-bash' --directory="custom-path-for-bash-$bash_version" --directory --touch)"
@@ -133,9 +133,9 @@ function debug_bash() (
 				cmd=(eval-helper --verbose --wrap --command="${cmd[*]/$PATH/\"\$PATH\"}" -- "${cmd[@]}")
 			fi
 			if [[ $option_continue == 'yes' ]]; then
-				"${cmd[@]}" || exit_status=$?
+				"${cmd[@]}" || __exit_status=$? # eval
 			else
-				"${cmd[@]}"
+				"${cmd[@]}" # eval
 			fi
 		done
 	else
@@ -149,8 +149,8 @@ function debug_bash() (
 		fi
 		"${cmd[@]}" # eval
 	fi
-	if [[ $exit_status -ne 0 ]]; then
-		return "$exit_status"
+	if [[ $__exit_status -ne 0 ]]; then
+		return "$__exit_status"
 	fi
 )