Skip to content

Suggestion: consider merging get-installer into setup-util, such that I can do setup-util --cli='thing' and it'll work #282

@balupton

Description

@balupton

It is a bit strange that get-installer is a seperate utility to setup-util, the origins of this go back to before setup-util was as full-fledged as it was, and there was a need for get-installer mappings to go to things other than setup-util-* commands.

The other constraint that required get-installer was its use of bash associative arrays, which is a bash v4 feature, and macos ships with bash v3. However, now that there is tooling within Dorothy for parsing json, we could just move the associative array to a json configuration file that setup-util loads.

The other change here, would actually also allow setup-util to handle groupings of installer methods. Such as be able to handle DOWNLOAD for a bottle, as well as DOWNLOAD for a github tarball. That would be doing setup-util --cli=<cli> -- [first batch of options] -- [second batch of options]. This is because to support setup-util --cli=<cli> to lookup <cli> and call the setup-util-<installer> command, we need to know if any options were passed.

There are probably other complexities here, such as handling all the weird options of get-installer, but it seems good.

Metadata

Metadata

Assignees

No one assigned

    Labels

    PR / Bounty onlyExternal demand, as such, external funding / effort is required to make this happenenhancementImprovement or suggestion

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions