v6.1.5 - typescsript es5 target adjustments

Author: balupton

HISTORY.md

@@ -1,5 +1,12 @@
 # History
 
+## v6.1.5 2025 August 8
+
+- Renamed the rule extensions for brevity and clarity
+- Add `eslint-config-bevry/typescript/es5` configuration for TypeScript ES5 targets, which ignores the `@typescript-eslint/prefer-for-of` rule, as it is not supported in ES5
+- Updated dependencies, [base files](https://github.com/bevry/base), and [editions](https://editions.bevry.me) using [boundation](https://github.com/bevry/boundation)
+- Thank you to the sponsors: [Andrew Nesbitt](https://nesbitt.io), [Divinci ™](https://divinci.ai), [Mr. Henry](https://mrhenry.be), [Poonacha Medappa](https://poonachamedappa.com), [Roboflow](https://roboflow.com), [Square](https://github.com/square)
+
 ## v6.1.4 2025 August 8
 
 - Disable potentially useful but broken `n/no-unsupported-features/es-syntax` rule, as it does not respect the `ecmaVersion` setting, and instead prefers to use the Node.js engine version, which is not what we want when using a transpiler, and is disrespectful as our configuration knows better, hence why there is even an `ecmaVersion` setting in the first place, they should rename this rule to `n/no-unsupported-features/node-syntax` as that it what it actually is

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-bevry",
-  "version": "6.1.4",
+  "version": "6.1.5",
   "license": "Artistic-2.0",
   "description": "Intelligent, self-configuring ESLint configuration that automatically analyzes your project structure, dependencies, and metadata to apply optimal linting rules for JavaScript, TypeScript, React, Node.js, and more.",
   "homepage": "https://github.com/bevry/eslint-config-bevry",
@@ -19,6 +19,7 @@
     "eslint",
     "eslint-config",
     "eslintconfig",
+    "esnext",
     "export-default",
     "flow",
     "flow-type",
@@ -120,7 +121,8 @@
     "WriterJohnBuck (https://github.com/WriterJohnBuck)"
   ],
   "engines": {
-    "node": ">=20"
+    "node": ">=20",
+    "ecmascript": ">= esnext"
   },
   "editions": [
     {
@@ -153,7 +155,7 @@
     "@eslint/js": "^9.33.0",
     "eslint-config-prettier": "^10.1.8",
     "eslint-plugin-import": "^2.32.0",
-    "eslint-plugin-jsdoc": "^53.0.0",
+    "eslint-plugin-jsdoc": "^53.0.1",
     "eslint-plugin-n": "^17.21.3",
     "eslint-plugin-react": "^7.37.5",
     "eslint-plugin-react-hooks": "^5.2.0",

package.json

@@ -60,9 +60,9 @@ const config = {
 			'**/edition-*/',
 			...(pkg.eslintConfig?.ignores || []),
 		]),
-		rules.beforeEslintRecommended,
+		rules.jsBefore,
 		eslintJS.configs.recommended,
-		rules.afterEslintRecommended,
+		rules.jsAfter,
 	],
 	languageOptions: {
 		// ecmaVersion: null,
@@ -315,10 +315,7 @@ if (sourceType === 'module') {
 	if (react) {
 		config.extends.push(eslintImport.flatConfigs.react)
 	}
-	config.extends.push(
-		eslintImport.flatConfigs.typescript,
-		rules.afterImportRecommended,
-	)
+	config.extends.push(eslintImport.flatConfigs.typescript, rules.importAfter)
 }
 
 // node
@@ -341,9 +338,9 @@ if (node) {
 		...globals.node,
 		...globals.nodeBuiltin,
 	}
-	config.extends.push(rules.afterNodeRecommended)
+	config.extends.push(rules.nodeAfter)
 	if (typescript || babel) {
-		config.extends.push(rules.afterNodeCompiledRecommended)
+		config.extends.push(rules.nodeCompiled)
 	}
 }
 if (browser) {
@@ -392,10 +389,13 @@ if (typescript) {
 		eslintTypescript.configs.stylisticTypeChecked,
 
 		// our overrides
-		rules.afterTypescriptRecommended,
+		rules.typescriptAfter,
 	)
+	if (ecmascriptVersionTarget <= 5) {
+		config.extends.push(rules.typescriptEs5)
+	}
 	if (ecmascriptVersionTarget <= 2015) {
-		config.extends.push(rules.typescriptEcmascript2015Target)
+		config.extends.push(rules.typescriptEs2015)
 	}
 	config.extends.push(rules.typescriptTests)
 } else {
@@ -418,7 +418,7 @@ if (prettier) {
 
 // this is after typescript, as we need to override defaults from typescript configs
 if (ecmascriptVersionSource <= 5) {
-	config.extends.push(rules.ecmascript5Source)
+	config.extends.push(rules.es5)
 }
 
 // user rules overrides

source/index.js

@@ -7,8 +7,8 @@ export const MAX_PARAMS = 4
 // Rules intended to be overwrote by ESLint Recommended
 // https://unpkg.com/@eslint/js@9/src/configs/eslint-recommended.js
 
-export const beforeEslintRecommended = {
-	name: 'eslint-config-bevry/before-eslint-recommended',
+export const jsBefore = {
+	name: 'eslint-config-bevry/js/before',
 	rules: {
 		// https://eslint.org/docs/latest/rules/constructor-super
 		// eslint/recommended will override this to error
@@ -200,8 +200,8 @@ export const beforeEslintRecommended = {
 // Rules intended to overwrite ESLint Recommended
 // https://unpkg.com/@eslint/js@9/src/configs/eslint-recommended.js
 
-export const afterEslintRecommended = {
-	name: 'eslint-config-bevry/rules-after-eslint-recommended',
+export const jsAfter = {
+	name: 'eslint-config-bevry/js/after',
 	rules: {
 		// https://eslint.org/docs/latest/rules/no-cond-assign
 		// eslint/recommended defaulted this to allow sometimes
@@ -1071,8 +1071,8 @@ export const afterEslintRecommended = {
 // Adjustments
 
 // These are adjustments based on the source ecmascript version, as the transpiler handles them
-export const ecmascript5Source = {
-	name: 'eslint-config-bevry/eslint-five',
+export const es5 = {
+	name: 'eslint-config-bevry/es5',
 	rules: {
 		'no-var': IGNORE,
 		'object-shorthand': [ERROR, 'never'],
@@ -1082,8 +1082,8 @@ export const ecmascript5Source = {
 	},
 }
 
-export const afterImportRecommended = {
-	name: 'eslint-config-bevry/after-import-recommended',
+export const importAfter = {
+	name: 'eslint-config-bevry/import/after',
 	rules: {
 		// https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/no-unresolved.md
 		// This is broken for javascript and typescript projects, including this project on `typescript-eslint` and `eslint-plugin-jsdoc`
@@ -1095,8 +1095,8 @@ export const afterImportRecommended = {
 // https://github.com/eslint-community/eslint-plugin-n?tab=readme-ov-file#-rules
 // https://github.com/eslint-community/eslint-plugin-n/blob/master/lib/all-rules.js
 // None of these should be set by the recommended configs
-export const afterNodeRecommended = {
-	name: 'eslint-config-bevry/after-node-recommended',
+export const nodeAfter = {
+	name: 'eslint-config-bevry/node/after',
 	rules: {
 		// https://eslint.org/docs/latest/rules/callback-return
 		// https://github.com/eslint-community/eslint-plugin-n/blob/master/docs/rules/callback-return.md
@@ -1145,17 +1145,17 @@ export const afterNodeRecommended = {
 	},
 }
 
-export const afterNodeCompiledRecommended = {
-	name: 'eslint-config-bevry/after-node-compiled-recommended',
+export const nodeCompiled = {
+	name: 'eslint-config-bevry/node/compiled',
 	rules: {
 		//https://github.com/eslint-community/eslint-plugin-n/blob/master/docs/rules//no-unsupported-features/es-syntax.md
 		// This rule is broken. It uses the node.js engine version instead of the specified ecmaVersion, and as we use a transpiler the Node.js engine version is expanded beyond the capabilities of our source. There is no configuration to get this rule to actually use the specificied ecmaVersion for the ecmascript syntax - this rule as such should be renamed to node-syntax, NOT es-syntax.
 		'n/no-unsupported-features/es-syntax': IGNORE,
 	},
 }
 
-export const afterTypescriptRecommended = {
-	name: 'eslint-config-bevry/after-typescript-recommended',
+export const typescriptAfter = {
+	name: 'eslint-config-bevry/typescript/after',
 	rules: {
 		// this typescript-eslint does not modify, however typescript handles them better
 		'no-use-before-define': IGNORE,
@@ -1185,18 +1185,23 @@ export const afterTypescriptRecommended = {
 	},
 }
 
-// @todo these may not be needed now that we are more aware of our ecmascript versions
 // These are adjustments based on the target ecmascript version, as the transpiler does not handle them
-export const typescriptEcmascript2015Target = {
-	name: 'eslint-config-bevry/typescript-ecmascript-2015-overrides',
+export const typescriptEs5 = {
+	name: 'eslint-config-bevry/typescript/es5',
+	rules: {
+		'@typescript-eslint/prefer-for-of': IGNORE, // came in ES2015
+	},
+}
+export const typescriptEs2015 = {
+	name: 'eslint-config-bevry/typescript/es2015',
 	rules: {
 		'@typescript-eslint/prefer-includes': IGNORE, // came in ES2016
 	},
 }
 
 // allow unsafe types in our test files, as how else are we meant to test that unsafe inputs will be handled correctly?
 export const typescriptTests = {
-	name: 'eslint-config-bevry/typescript-test-overrides',
+	name: 'eslint-config-bevry/typescript/tests',
 	files: ['**/test.{js,cjs,mjs,jsx,mjsx,ts,cts,mts,tsx,mtsx}'],
 	rules: {
 		'@typescript-eslint/no-explicit-any': WARN,