Fix debug crash on BAR's legmohobp and document why it crashed

lhog · lhog · commit a2de4de34473 · 2025-10-27T00:30:26.000+01:00
diff --git a/rts/Sim/Units/Scripts/UnitScript.cpp b/rts/Sim/Units/Scripts/UnitScript.cpp
@@ -260,7 +260,8 @@ void CUnitScript::TickAllAnims(int deltaTime)
 #endif
 #ifdef _DEBUG
 	for (auto* p : pieces) {
-		assert(!p->GetDirty());
+		// NOTE: p can actually be nullptr when the cob script mentions pieces that don't exist in the model!
+		if (p) assert(!p->GetDirty());
 	}
 #endif // _DEBUG
 

Original file line number	Diff line number	Diff line change
`@@ -260,7 +260,8 @@ void CUnitScript::TickAllAnims(int deltaTime)`
`260`	`260`	`#endif`
`261`	`261`	`#ifdef _DEBUG`
`262`	`262`	`for (auto* p : pieces) {`
`263`		`- assert(!p->GetDirty());`
	`263`	`+ // NOTE: p can actually be nullptr when the cob script mentions pieces that don't exist in the model!`
	`264`	`+ if (p) assert(!p->GetDirty());`
`264`	`265`	`}`
`265`	`266`	`#endif // _DEBUG`
`266`	`267`