Fix GH #350

Author: petdance

Changes

@@ -6,6 +6,11 @@ The --not option can be used with either --and or --or.
 
 The -g option can now use any of the boolean options, --and, --or or --not.
 
+[FIXES]
+When using --output='$f', the filename would be colorized in the output
+line, but should not have been.  This has been fixed. Thanks, Dabrien
+'Dabe' Murphy. (GH #350)
+
 
 v3.8.2      Sun Apr  6 10:45:04 CDT 2025
 ========================================

MANIFEST

@@ -59,6 +59,7 @@ t/ack-n.t
 t/ack-o.yaml
 t/ack-output.t
 t/ack-output.yaml
+t/ack-output-color.t
 t/ack-pager.t
 t/ack-passthru.t
 t/ack-print0.t

ack

@@ -904,20 +904,29 @@ sub print_line_with_options {
     my @line_parts;
 
     if ( $opt_show_filename && defined($filename) ) {
-        my $colno;
-        $colno = get_match_colno() if $opt_column;
+        my $disp_filename;
+        my $disp_lineno;
         if ( $opt_color ) {
-            $filename = Term::ANSIColor::colored( $filename, $ENV{ACK_COLOR_FILENAME} );
-            $lineno   = Term::ANSIColor::colored( $lineno,   $ENV{ACK_COLOR_LINENO} );
-            $colno    = Term::ANSIColor::colored( $colno,    $ENV{ACK_COLOR_COLNO} ) if $opt_column;
+            $disp_filename = Term::ANSIColor::colored( $filename, $ENV{ACK_COLOR_FILENAME} );
+            $disp_lineno   = Term::ANSIColor::colored( $lineno,   $ENV{ACK_COLOR_LINENO} );
         }
+        else {
+            $disp_filename = $filename;
+            $disp_lineno   = $lineno;
+        }
+
         if ( $opt_heading ) {
-            push @line_parts, $lineno;
+            push @line_parts, $disp_lineno;
         }
         else {
-            push @line_parts, $filename, $lineno;
+            push @line_parts, $disp_filename, $disp_lineno;
+        }
+
+        if ( $opt_column ) {
+            my $colno = get_match_colno();
+            $colno = Term::ANSIColor::colored( $colno, $ENV{ACK_COLOR_COLNO} ) if $opt_color;
+            push @line_parts, $colno;
         }
-        push @line_parts, $colno if $opt_column;
     }
 
     if ( $opt_output ) {