You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Feb 14, 2026. It is now read-only.
Did you consider lifting the state up? I think this might make the implmentation a bit neater. keyboardController.keys could be passed to ControlsModal. You could then have a setKey method on KeyboardController that was passed all the way down to each row. That way the state management and business logic is all in KeyboardController.
Is there a reason why it is persisted on unload rather than on every key change? I would have thought setting local storage is pretty cheap. That way you wouldn't have to check if state were modified and the keys would still persist if unload wasn't called for whatever reason.
From review in #136:
keyboardController.keyscould be passed toControlsModal. You could then have asetKeymethod onKeyboardControllerthat was passed all the way down to each row. That way the state management and business logic is all inKeyboardController.