Skip to content

Commit 99f6756

Browse files
bfirshclaude
andcommitted
Move mapper names from rom.js to each mapper class
The ROM class had a large array mapping mapper numbers to names, which was only used in an error message that always showed "Unknown Mapper" for unsupported mappers. Move names to static mapperName properties on each mapper class and correct them to match nesdev wiki nomenclature. Remove the now-unused getMapperName() method. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent c8b67b2 commit 99f6756

File tree

17 files changed

+32
-53
lines changed

17 files changed

+32
-53
lines changed

src/mappers/mapper0.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
import { copyArrayElements } from "../utils.js";
22

33
class Mapper0 {
4+
static mapperName = "NROM";
5+
46
constructor(nes) {
57
this.nes = nes;
68

src/mappers/mapper1.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
import Mapper0 from "./mapper0.js";
22

33
class Mapper1 extends Mapper0 {
4+
static mapperName = "MMC1";
5+
46
constructor(nes) {
57
super(nes);
68

src/mappers/mapper11.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ import Mapper0 from "./mapper0.js";
77
* @example Crystal Mines, Metal Fighter
88
*/
99
class Mapper11 extends Mapper0 {
10+
static mapperName = "Color Dreams";
11+
1012
constructor(nes) {
1113
super(nes);
1214
}

src/mappers/mapper140.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ import Mapper0 from "./mapper0.js";
77
* @example Bio Senshi Dan - Increaser Tono Tatakai
88
*/
99
class Mapper140 extends Mapper0 {
10+
static mapperName = "Jaleco JF-11/JF-14";
11+
1012
constructor(nes) {
1113
super(nes);
1214
}

src/mappers/mapper180.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ import Mapper0 from "./mapper0.js";
77
* @example Crazy Climber
88
*/
99
class Mapper180 extends Mapper0 {
10+
static mapperName = "UNROM (Crazy Climber)";
11+
1012
constructor(nes) {
1113
super(nes);
1214
}

src/mappers/mapper2.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
import Mapper0 from "./mapper0.js";
22

33
class Mapper2 extends Mapper0 {
4+
static mapperName = "UxROM";
5+
46
constructor(nes) {
57
super(nes);
68
}

src/mappers/mapper240.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ import Mapper0 from "./mapper0.js";
88
* https://blog.heheda.top
99
*/
1010
class Mapper240 extends Mapper0 {
11+
static mapperName = "Mapper 240";
12+
1113
constructor(nes) {
1214
super(nes);
1315
}

src/mappers/mapper241.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ import Mapper0 from "./mapper0.js";
77
* https://blog.heheda.top
88
*/
99
class Mapper241 extends Mapper0 {
10+
static mapperName = "BxROM (Mapper 241)";
11+
1012
constructor(nes) {
1113
super(nes);
1214
}

src/mappers/mapper3.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ import Mapper0 from "./mapper0.js";
77
* @description http://wiki.nesdev.com/w/index.php/INES_Mapper_003
88
*/
99
class Mapper3 extends Mapper0 {
10+
static mapperName = "CNROM";
11+
1012
constructor(nes) {
1113
super(nes);
1214
}

src/mappers/mapper34.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ import Mapper0 from "./mapper0.js";
77
* @example Darkseed, Mashou, Mission Impossible 2
88
*/
99
class Mapper34 extends Mapper0 {
10+
static mapperName = "BNROM";
11+
1012
constructor(nes) {
1113
super(nes);
1214
}

0 commit comments

Comments
 (0)