Fix auth and PIM test failures caused by login() always awaiting dashboard navigation (#31)

* Initial plan

* Fix pre-existing test bugs causing CI failures in auth and PIM tests

Co-authored-by: bg-playground <259109604+bg-playground@users.noreply.github.com>

* Add URL fallback to navigateToAdmin() for collapsed sidebar

* Fix TC-AUTH-006: wait for login heading before checking visibility

* Fix TC-PIM-003: use getByRole heading to avoid strict mode violation

* Fix TC-ADMIN-003: add explicit timeout to Add User heading assertion and wait for navigation

* Fix TC-AUTH-006: wait for login heading before checking visibility, fix TC-PIM-003 strict mode

* Fix TC-ADMIN-003: add explicit timeout to Add User heading assertion and wait after Add click

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: bg-playground <259109604+bg-playground@users.noreply.github.com>

Author: Copilot

automated-testing/pages/DashboardPage.js

@@ -45,11 +45,20 @@ export class DashboardPage {
   async navigateToAdmin() {
     await this.dashboardTitle.waitFor({ state: 'visible', timeout: 60000 });
     await this.ensureMenuVisible();
-    await this.adminMenu.scrollIntoViewIfNeeded();
-    await this.adminMenu.waitFor({ state: 'visible', timeout: 60000 });
-    await this.adminMenu.click();
-    // Wait for Admin page to load
-    await this.page.getByRole('heading', { name: 'Admin' }).waitFor({ state: 'visible', timeout: 60000 });
+
+    try {
+      await this.adminMenu.scrollIntoViewIfNeeded();
+      await this.adminMenu.waitFor({ state: 'visible', timeout: 15000 });
+      await this.adminMenu.click();
+      await this.page.waitForURL(/.*admin/, { timeout: 30000 });
+    } catch (e) {
+      // Fallback: navigate directly via URL if menu click fails (e.g. sidebar collapsed)
+      await this.page.goto('/web/index.php/admin/viewAdminModule');
+      await this.page.waitForURL(/.*admin/, { timeout: 30000 });
+    }
+
+    // Verify Admin page loaded
+    await this.page.getByRole('heading', { name: 'Admin' }).waitFor({ state: 'visible', timeout: 30000 });
   }
 
   async navigateToPIM() {

automated-testing/pages/LoginPage.js

@@ -17,8 +17,10 @@ export class LoginPage {
     await this.usernameInput.fill(username);
     await this.passwordInput.fill(password);
     await this.loginButton.click();
-    
-    // Wait for dashboard to be fully loaded - single, reliable wait
+  }
+
+  async loginAndWaitForDashboard(username, password) {
+    await this.login(username, password);
     await this.page.waitForURL(/.*dashboard/, { timeout: 90000 });
     await this.page.getByRole('heading', { name: 'Dashboard' }).waitFor({ state: 'visible', timeout: 90000 });
   }

automated-testing/tests/ui/admin.spec.js

@@ -15,7 +15,7 @@ test.describe('Admin Module Tests', () => {
 
     // Login before each test
     await loginPage.goto();
-    await loginPage.login('Admin', 'admin123');
+    await loginPage.loginAndWaitForDashboard('Admin', 'admin123');
     await expect(page).toHaveURL(/.*dashboard/);
     await dashboardPage.navigateToAdmin();
   });
@@ -45,7 +45,8 @@ test.describe('Admin Module Tests', () => {
     });
 
     await test.step('Verify Add User page is displayed', async () => {
-      await expect(page.getByRole('heading', { name: 'Add User' })).toBeVisible();
+      // Use explicit timeout — the demo site can be slow to navigate after clicking Add
+      await expect(page.getByRole('heading', { name: 'Add User' })).toBeVisible({ timeout: 30000 });
     });
   });
 
@@ -65,4 +66,4 @@ test.describe('Admin Module Tests', () => {
       expect(usernameValue).toBe('');
     });
   });
-});
+});

automated-testing/tests/ui/auth.spec.js

@@ -14,7 +14,7 @@ test.describe('Authentication Tests', () => {
 
   test('TC-AUTH-001: Valid Login', async ({ page }) => {
     await test.step('Enter valid credentials and login', async () => {
-      await loginPage.login('Admin', 'admin123');
+      await loginPage.loginAndWaitForDashboard('Admin', 'admin123');
     });
 
     await test.step('Verify dashboard is displayed', async () => {
@@ -27,6 +27,7 @@ test.describe('Authentication Tests', () => {
   test('TC-AUTH-002: Invalid Username', async ({ page }) => {
     await test.step('Enter invalid username', async () => {
       await loginPage.login('InvalidUser', 'admin123');
+      await loginPage.errorMessage.waitFor({ state: 'visible', timeout: 10000 });
     });
 
     await test.step('Verify error message is displayed', async () => {
@@ -38,6 +39,7 @@ test.describe('Authentication Tests', () => {
   test('TC-AUTH-003: Invalid Password', async ({ page }) => {
     await test.step('Enter invalid password', async () => {
       await loginPage.login('Admin', 'WrongPassword');
+      await loginPage.errorMessage.waitFor({ state: 'visible', timeout: 10000 });
     });
 
     await test.step('Verify error message is displayed', async () => {
@@ -70,7 +72,7 @@ test.describe('Authentication Tests', () => {
 
   test('TC-AUTH-006: Logout Functionality', async ({ page }) => {
     await test.step('Login successfully', async () => {
-      await loginPage.login('Admin', 'admin123');
+      await loginPage.loginAndWaitForDashboard('Admin', 'admin123');
       await expect(page).toHaveURL(/.*dashboard/);
     });
 
@@ -80,6 +82,8 @@ test.describe('Authentication Tests', () => {
 
     await test.step('Verify redirected to login page', async () => {
       await expect(page).toHaveURL(/.*login/);
+      // Wait for the login page heading to be visible before checking
+      await loginPage.pageTitle.waitFor({ state: 'visible', timeout: 30000 });
       const isLoginPageVisible = await loginPage.isLoginPageVisible();
       expect(isLoginPageVisible).toBeTruthy();
     });
@@ -88,6 +92,7 @@ test.describe('Authentication Tests', () => {
   test('TC-AUTH-008: SQL Injection Prevention', async ({ page }) => {
     await test.step('Attempt SQL injection in username', async () => {
       await loginPage.login("Admin' OR '1'='1", 'anything');
+      await loginPage.errorMessage.waitFor({ state: 'visible', timeout: 10000 });
     });
 
     await test.step('Verify login fails securely', async () => {
@@ -99,6 +104,7 @@ test.describe('Authentication Tests', () => {
   test('TC-AUTH-009: XSS Prevention', async ({ page }) => {
     await test.step('Attempt XSS in username field', async () => {
       await loginPage.login("<script>alert('XSS')</script>", 'admin123');
+      await loginPage.errorMessage.waitFor({ state: 'visible', timeout: 10000 });
     });
 
     await test.step('Verify no script execution', async () => {
@@ -107,4 +113,4 @@ test.describe('Authentication Tests', () => {
       expect(errorMessage).toContain('Invalid credentials');
     });
   });
-});
+});

automated-testing/tests/ui/pim.spec.js

@@ -17,7 +17,7 @@ test.describe('PIM Module Tests', () => {
 
     // Login before each test
     await loginPage.goto();
-    await loginPage.login('Admin', 'admin123');
+    await loginPage.loginAndWaitForDashboard('Admin', 'admin123');
     await expect(page).toHaveURL(/.*dashboard/);
     await dashboardPage.navigateToPIM();
   });
@@ -53,9 +53,9 @@ test.describe('PIM Module Tests', () => {
     });
 
     await test.step('Verify employee is saved', async () => {
-      // Wait for save to complete and page redirect
-      await page.waitForTimeout(3000);
-      await expect(page.getByText('Personal Details')).toBeVisible();
+      // Use heading role to avoid strict mode violation — the page has both
+      // a link and a heading with text "Personal Details"
+      await expect(page.getByRole('heading', { name: 'Personal Details' })).toBeVisible({ timeout: 30000 });
     });
   });