Skip to content

Commit ee5f091

Browse files
committed
fix: update workflow
1 parent d96c7a5 commit ee5f091

File tree

4 files changed

+21
-50
lines changed

4 files changed

+21
-50
lines changed

.github/workflows/comment.yml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,22 @@ name: PR Comment
22

33
on:
44
workflow_run:
5+
# The workflow generating the artifacts
56
workflows: [Test]
67
types:
78
- completed
89

10+
permissions:
11+
actions: read
12+
issues: write
13+
checks: read
14+
statuses: read
15+
pull-requests: write
16+
917
jobs:
1018
comment:
1119
uses: bgd-labs/github-workflows/.github/workflows/comment.yml@main
1220
secrets:
21+
# the provided PAT needs write and write permissions on issues and pull requests
22+
# the PAT is only really needed when commenting of prs from forks
1323
READ_ONLY_PAT: ${{ secrets.READ_ONLY_PAT }}

.github/workflows/test.yml

Lines changed: 9 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -1,59 +1,20 @@
11
name: Test
22

33
concurrency:
4-
group: ${{ github.head_ref || github.run_id }}
4+
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
55
cancel-in-progress: true
66

77
on:
88
pull_request:
99
push:
10-
branches:
11-
- main
10+
branches: [main]
11+
12+
permissions:
13+
contents: write
14+
pull-requests: write
1215

1316
jobs:
1417
lint:
15-
runs-on: ubuntu-latest
16-
steps:
17-
- uses: actions/checkout@v4
18-
19-
- name: Run Foundry setup
20-
uses: bgd-labs/github-workflows/.github/actions/foundry-setup@main
21-
22-
- name: Enforce linting
23-
run: forge fmt --check
24-
25-
test-sol:
26-
name: Foundry build n test
27-
runs-on: ubuntu-latest
28-
steps:
29-
- uses: actions/checkout@v4
30-
with:
31-
submodules: recursive
32-
33-
- uses: bgd-labs/action-rpc-env@main
34-
with:
35-
ALCHEMY_API_KEY: ${{ secrets.ALCHEMY_API_KEY }}
36-
37-
# we simply use foundry zk for all jobs in this repo
38-
- name: Run Foundry setup
39-
uses: bgd-labs/github-workflows/.github/actions/foundry-setup@main
40-
41-
- name: Run Forge tests
42-
id: test
43-
uses: bgd-labs/github-workflows/.github/actions/foundry-test@main
44-
45-
- name: Run Gas report
46-
uses: bgd-labs/github-workflows/.github/actions/foundry-gas-report@main
47-
48-
- name: Run Lcov report
49-
uses: bgd-labs/github-workflows/.github/actions/foundry-lcov-report@main
50-
51-
- name: Store artifact
52-
uses: bgd-labs/github-workflows/.github/actions/comment-artifact@main
53-
54-
# we let failing tests pass so we can log them in the comment, still we want the ci to fail
55-
- name: Post test
56-
if: ${{ steps.test.outputs.testStatus != 0 || steps.zktest.outputs.testStatus != 0 }}
57-
run: |
58-
echo "tests failed"
59-
exit 1
18+
uses: bgd-labs/github-workflows/.github/workflows/foundry-lint.yml@main
19+
test:
20+
uses: bgd-labs/github-workflows/.github/workflows/foundry-test.yml@main

lib/aave-helpers

Submodule aave-helpers updated 83 files

0 commit comments

Comments
 (0)