Migrate to Paraswap V6 #32
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "dependencies": { | ||
| "@paraswap/sdk": "^6.2.1", | ||
| "@paraswap/core": "^2.4.0", | ||
| "@paraswap/sdk": "^6.11.0", |
Contributor
There was a problem hiding this comment.
why do we need this new dependency?
| abstract contract BaseParaSwapBuyAdapter is BaseParaSwapAdapter { | ||
| using SafeERC20 for IERC20Detailed; | ||
| using PercentageMath for uint256; | ||
| using SafeMath for uint256; |
Contributor
There was a problem hiding this comment.
SafeMath is not needed since we are >0.8.0
Contributor
|
LGTM! Thanks, @CheyenneAtapour, for the work. Based on our chat with the Paraswap team, it looks like contract changes aren’t needed for V6 support since it’s compatible with TokenTransferProxy and AugustusRegistry, so we'll put this PR on hold for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main change is the removal of
TokenTransferProxygiven that this contract is no longer executing token transfers (butAugustusinstead).Closes #30