Skip to content

Commit 5f980a9

Browse files
docs: add pre-review checklist (#891)
* chore: add pre-review checklist * docs: update checklist from feedback * docs: fix grammar
1 parent 06c1557 commit 5f980a9

File tree

1 file changed

+11
-0
lines changed

1 file changed

+11
-0
lines changed

.github/pull_request_template.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
### Pre-review checklist:
2+
3+
- [ ] I have run a spell check on the write-up and made sure no typos exist.
4+
- [ ] References to Snapshot/governance forum are correct on the AIP. If no snapshot exists, make sure no TODO's exist.
5+
- [ ] The specification on the writeup is aligned with the forum, snapshot, and the payload contract. If there are any changes, they are explicitly mentioned/communicated.
6+
- [ ] Minimal tests exist, and the snapshot diff report generated is the latest one and aligned with the payload.
7+
- [ ] If deploy scripts are manually updated from the generated ones, I have carefully validated that they are correct, including the deploy commands and the proposal-creation script.
8+
- [ ] If the aave-helpers submodule is updated, I have validated it is pointing to the latest version.
9+
- [ ] I have validated that no unused files and imports are being added.
10+
- [ ] For an asset listing, the write-up includes a detailed specification of the price feed used, CAPO adapters (with each CAPO layer described separately), and eModes (with tables) if changed.
11+
- [ ] Wherever possible, I have validated that addresses from the address book are used instead of raw addresses.

0 commit comments

Comments
 (0)