-
Notifications
You must be signed in to change notification settings - Fork 38
Description
One thing i noticed is quite suboptimal with configs:
When i initially created the generator, the goal was simple:
ask some questions -> generate code
but now as we added the config.json output(because gauntlet requested it and seems useful) idk if some old design decisions make sense
In the case of ACI proposal for example:
#3
they share the config.json, but if you would now use this same config.json with all issues patched, still wrong code would be generated.
The reason is that the json does not store "raw" values, but already stores the formatted output.
"eModeCategory": "AaveV3EthereumEModes.NONE",
"optimalUtilizationRate": "_bpsToRay(45_00)",
"enabledToBorrow": "ENABLED",
So patches to the formatter don't have any effect.
I think make sense to remove the "automatic formating" inside the cli step and instead store the "raw value".
The formatting should probably only happen on the build step.