Skip to content

Conversation

@NandyBa
Copy link
Contributor

@NandyBa NandyBa commented Nov 11, 2025

Pre-review checklist:

  • I have run a spell check on the write-up and made sure no typos exist.
  • References to Snapshot/governance forum are correct on the AIP. If no snapshot exists, make sure no TODO's exist.
  • The specification on the writeup is aligned with the forum, snapshot, and the payload contract. If there are any changes, they are explicitly mentioned/communicated.
  • Minimal tests exist, and the snapshot diff report generated is the latest one and aligned with the payload.
  • If deploy scripts are manually updated from the generated ones, I have carefully validated that they are correct, including the deploy commands and the proposal-creation script.
  • If the aave-helpers submodule is updated, I have validated it is pointing to the latest version.
  • I have validated that no unused files and imports are being added.
  • For an asset listing, the write-up includes a detailed specification of the price feed used, CAPO adapters (with each CAPO layer described separately), and eModes (with tables) if changed.
  • Wherever possible, I have validated that addresses from the address book are used instead of raw addresses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant