Address Copilot boundary feedback

Author: bglusman

crates/calciforge/src/proxy/helicone_router_tests.rs

@@ -144,6 +144,58 @@ async fn chat_completion_posts_to_configured_v1_path_without_duplication() {
     mock.assert_async().await;
 }
 
+#[tokio::test]
+async fn chat_completion_accepts_helicone_streaming_response() {
+    let mut server = mockito::Server::new_async().await;
+    let body = concat!(
+        "data: {\"id\":\"chatcmpl-stream\",\"object\":\"chat.completion.chunk\",\"created\":1,\"model\":\"openai/gpt-4o-mini\",\"choices\":[{\"index\":0,\"delta\":{\"role\":\"assistant\",\"content\":\"po\"},\"finish_reason\":null}]}\n\n",
+        "data: {\"id\":\"chatcmpl-stream\",\"object\":\"chat.completion.chunk\",\"created\":1,\"model\":\"openai/gpt-4o-mini\",\"choices\":[{\"index\":0,\"delta\":{\"content\":\"ng\"},\"finish_reason\":\"stop\"}]}\n\n",
+        "data: [DONE]\n\n",
+    );
+    let mock = server
+        .mock("POST", "/v1/chat/completions")
+        .match_body(Matcher::PartialJson(serde_json::json!({
+            "model": "openai/gpt-4o-mini",
+            "stream": true
+        })))
+        .with_status(200)
+        .with_header("content-type", "text/event-stream; charset=utf-8")
+        .with_body(body)
+        .create_async()
+        .await;
+
+    let router = HeliconeRouter::new(config(format!("{}/v1/", server.url()))).unwrap();
+    let result = router
+        .chat_completion(
+            "openai/gpt-4o-mini".to_string(),
+            vec![ChatMessage {
+                role: "user".to_string(),
+                content: Some(MessageContent::Text("hello".to_string())),
+                name: None,
+                tool_calls: None,
+                tool_call_id: None,
+                reasoning: None,
+                reasoning_content: None,
+            }],
+            true,
+            None,
+            None,
+        )
+        .await
+        .unwrap();
+
+    assert_eq!(
+        result.choices[0]
+            .message
+            .content
+            .as_ref()
+            .and_then(MessageContent::to_text)
+            .as_deref(),
+        Some("pong")
+    );
+    mock.assert_async().await;
+}
+
 #[tokio::test]
 async fn chat_completion_forwards_custom_headers() {
     let mut server = mockito::Server::new_async().await;

crates/calciforge/src/proxy/helicone_streaming.rs

@@ -200,12 +200,18 @@ pub(super) fn parse_streaming_chat_completion(
     for (index, accumulator) in choices_by_index {
         let mut tool_call_entries: Vec<(u32, ToolCall)> = Vec::new();
         for (tool_index, call) in accumulator.tool_calls {
-            let Some(id) = call.id else {
-                continue;
-            };
-            let Some(name) = call.name else {
-                continue;
-            };
+            let id = call.id.ok_or_else(|| {
+                BackendError::InvalidResponse(format!(
+                    "Helicone streaming tool call for model '{}' did not include an id",
+                    requested_model
+                ))
+            })?;
+            let name = call.name.ok_or_else(|| {
+                BackendError::InvalidResponse(format!(
+                    "Helicone streaming tool call for model '{}' did not include a function name",
+                    requested_model
+                ))
+            })?;
             tool_call_entries.push((
                 tool_index,
                 ToolCall {
@@ -433,6 +439,22 @@ mod tests {
         );
     }
 
+    #[test]
+    fn rejects_incomplete_streamed_tool_calls() {
+        let body = concat!(
+            "data: {\"id\":\"chatcmpl-tools\",\"object\":\"chat.completion.chunk\",\"created\":6,\"model\":\"ollama/qwen3.6:27b\",\"choices\":[{\"index\":0,\"delta\":{\"role\":\"assistant\",\"tool_calls\":[{\"index\":0,\"type\":\"function\",\"function\":{\"arguments\":\"{}\"}}]},\"finish_reason\":\"tool_calls\"}]}\n\n",
+            "data: [DONE]\n\n",
+        );
+
+        let error = parse_streaming_chat_completion(body, "ollama/qwen3.6:27b")
+            .expect_err("missing tool call id/name should not become a successful response");
+
+        assert!(
+            error.to_string().contains("did not include an id"),
+            "unexpected error: {error}"
+        );
+    }
+
     proptest! {
         #[test]
         fn arbitrary_stream_bodies_never_panic(body in ".*") {

scripts/check-scenarios.py

@@ -30,7 +30,11 @@ def fail(message: str) -> None:
 
 def require_nonempty_list(scenario: dict, key: str) -> None:
     value = scenario.get(key)
-    if not isinstance(value, list) or not value or not all(isinstance(item, str) and item for item in value):
+    if (
+        not isinstance(value, list)
+        or not value
+        or not all(isinstance(item, str) and item.strip() for item in value)
+    ):
         fail(f"{scenario.get('id', '<unknown>')}: {key} must be a non-empty list of strings")
 
 

scripts/model-gateway-route-aggression.py

@@ -24,16 +24,21 @@
 
 
 DEFAULT_CONFIG_PATHS = (
-    Path(os.environ.get("CALCIFORGE_CONFIG", "")),
     Path.home() / ".config" / "calciforge" / "config.toml",
     Path("/opt/homebrew/etc/calciforge/config.toml"),
     Path("/etc/calciforge/config.toml"),
 )
 
 
 def existing_default_config() -> Path | None:
+    env_path = os.environ.get("CALCIFORGE_CONFIG", "").strip()
+    if env_path:
+        path = Path(env_path)
+        if path.is_file():
+            return path
+
     for path in DEFAULT_CONFIG_PATHS:
-        if str(path) and path.exists():
+        if path.is_file():
             return path
     return None
 

scripts/ollama-model-switch.sh

@@ -97,6 +97,10 @@ if truthy "$warmup_enabled" && [[ "$target_loaded" != true ]]; then
         keep_alive="${CALCIFORGE_OLLAMA_KEEP_ALIVE:-24h}"
         warmup_timeout="${CALCIFORGE_OLLAMA_WARMUP_TIMEOUT_SECONDS:-120}"
         warmup_ctx="${CALCIFORGE_OLLAMA_WARMUP_CONTEXT:-1024}"
+        if [[ ! "$warmup_ctx" =~ ^[0-9]+$ ]]; then
+            echo "warning: invalid CALCIFORGE_OLLAMA_WARMUP_CONTEXT='$warmup_ctx'; using 1024" >&2
+            warmup_ctx=1024
+        fi
         payload="$(printf \
             '{"model":"%s","prompt":"Reply with exactly: ready","stream":false,"keep_alive":"%s","options":{"num_ctx":%s}}\n' \
             "$(json_escape "$target")" \