Skip to content

Conversation

@mszinte
Copy link

@mszinte mszinte commented Jun 15, 2022

Important

This BEP is under community review from September 29 - October 10, 2025. Please participate at #2218.

Here is the specifications of the BEP 020 about eye tracking.

  • it follows the main discussion initiated on a google document.
  • it includes the different modification the group of maintainers suggested to us during our zoom meeting.
  • it includes the macros as used in other modality specific extensions
  • it includes links toward dataset examples.

Note

We meet regularly and everyone is welcome :
Next meeting April 3rd 2025 4pm UTC (EST 11am, PST 8am, CET 5pm, GMT 4pm) on zoom.

Note that if you consider joining but this time or day doesn't suits you, reach me (@mszinte) and I will arrange another appointment.

Notes of last meeting

Chat and discussions also happening on matrix

We are currently drafing a companion paper for this BEP, feel free to participate (GoogleDoc)

Issues for:


  • implement macros
    • for filename templates ?
    • for examples ?
    • for metadata table
  • add contributors to the wiki (so they can be added to the contributors page)
  • end docmentation
  • update examples
  • update validator
  • update list of contributors via the github wiki

@mszinte mszinte requested a review from tsalo as a code owner June 15, 2022 12:09
correction of text
@sappelhoff sappelhoff added the BEP label Jul 12, 2022
@sappelhoff
Copy link
Member

(NOTE: I'll cross-post this message across several BEP threads)

Hi there, just a quick notification that we have just merged #918 and it may be interesting to look at the implications for this BEP.

We are introducing "BIDS URIs", which unify the way we refer to and point to files in BIDS datasets (as opposed to "dataset-relative" or "subject-relative" or "file-relative" links).

If the diff and discussion in the PR is unclear, you can also read the rendered version: https://bids-specification.readthedocs.io/en/latest/02-common-principles.html#bids-uri

Perhaps there are things in the BEP that need adjusting now, but perhaps also not -- in any case it's good to be aware of this new feature!

Let me know if there are any questions, comments, or concerns.

@tsalo tsalo changed the title [ENH] Bep020 [ENH] BEP 020 Eye Tracking Aug 24, 2022
Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more foreignindexcolumns

Co-authored-by: Julia-Katharina Pfarr <[email protected]>
@effigies
Copy link
Collaborator

I have opened mszinte#12 to address the two comments in @yarikoptic's review. It is easily addressed in the schema with no validator changes necessary.

@gbezold1 @julia-pfarr @mszinte Would you have a look?

Copy link
Collaborator

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some clarifications needed as spotted during quick review

Comment on lines +1492 to +1493
Description of gaze-mapping settings.
For example, threshold on pupil confidence required for gaze mapping.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Description" suggests a text field but it is an object. But then it talks about items like in an array (of types object). I didn't find any other case like that in the schema and not sure if it is legit. @effigies might be able to help clarifying this for me.

If it is to be a dictionary (object) of some settings, may be some could at least recommend naming (in description) on some of those fields names?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same seems to apply to many other fields!

Note also that there is no example for GazeMappingSettings in the text, which again, leaves reader with a question on what it should contain and in what form.

name: RecordedEye
display_name: Recorded Eye
description: |
Indicates the eye tracked, for example, `"left"` or `"right"`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that there was an agreement on consistent use of "eye-tracking" hence I think:

Suggested change
Indicates the eye tracked, for example, `"left"` or `"right"`.
Indicates the eye-tracked, for example, `"left"` or `"right"`.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and adjust title of the PR (will get into changelog right?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BEP eye-tracking physio Proposed BEP see https://bids.neuroimaging.io/collaboration/governance.html#proposed-bep

Projects

None yet

Development

Successfully merging this pull request may close these issues.