-
Notifications
You must be signed in to change notification settings - Fork 190
BEP-038: Atlases #1714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
effigies
wants to merge
150
commits into
master
Choose a base branch
from
bep038
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
BEP-038: Atlases #1714
Changes from 93 commits
Commits
Show all changes
150 commits
Select commit
Hold shift + click to select a range
9878702
First draft of the atlas spec
melanieganz 8304769
Added proper content
melanieganz 01178db
First pass of adding BEP038 content
melanieganz 81d5ccc
Fixed details
melanieganz 7626992
case 3 files renamed
melanieganz 11ed800
update wording and fix typos in atlas.md
PeerHerholz 1129d8d
add draft for outlining desc- usage
PeerHerholz 6881c9c
add ref to template and lnter
CPernet e2b3ddb
Remove trailing whitespace, normalize indentation to two spaces
effigies f7a268d
Run codespell and aspell
effigies a96ab79
Replace i.e. and e.g.
effigies 18e2bcc
Line break at sentences, format nested list as markdown
effigies 803f0d4
Replace unicode quotes with ASCII
effigies dda4790
Include atlas.md in table of contents
effigies ba30c0e
Semantic line breaks, mostly at commas
effigies 9c803d7
FIX: Whitespace in schema.objects.entities.atlas.description
effigies 33e55b5
Merge pull request #1 from effigies/bep038
PeerHerholz 9baaeec
Merge branch 'master' into bep038
effigies 4fa15e5
first iteration of the alternative proposal
oesteban 0180e3b
STY: codespell
effigies bba4159
Replace links to the schema with links to the glossary
effigies f159e61
enh: generalization of atlas metadata cc/ @jdkent
oesteban 9390602
enh: address some of @effigies' comments
oesteban 3f8c210
enh: reference entities from glossary
oesteban 927335c
fix: folder => directory
oesteban 6a3dcc7
fix: resolving issues with/within entities
oesteban f7e906d
enh: add mention to transforms files cc/ @peerherholz
oesteban 57160cd
fix: revise more glossary links
oesteban 1db3fd4
enh: move all filetree examples to macros
oesteban 48e77ae
enh: miscellaneous improvements (sort entries in examples, etc.)
oesteban d6cf6a4
enh: improve intro
oesteban 8bfc7ac
enh: add datatype comment to make it recommended cc/ @effigies
oesteban f2be20a
enh: start drafting cohort
oesteban d15677a
enh: add multi-cohort example
oesteban b275ca3
fix: pacify pre-commit build
oesteban f9ff346
enh: add the PS13 example
oesteban f0e8e0e
test
jdkent b00bdf8
Update src/derivatives/atlas.md
jdkent abe37b4
Update src/derivatives/atlas.md
jdkent d812b08
incorporate meeting feedback in schema
jdkent 3accb28
enh: add note about 'MNI Space' below template identifiers @CPernet
oesteban e5e27f1
enh: clarify the creation of BOTH a new template AND atlas
oesteban 8ffda51
fix: avoid using an atlas name for a segmentation label
oesteban d62f0d9
enh: rework the text to clarify notions: atlas, template, space
oesteban 161db11
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 44cb808
fix: addressing some inconsistencies about segmentations
oesteban c77df10
fix: add clarification about cohort
oesteban 947f279
fix: replace ``_mimap`` with ``_pet``
oesteban a5111aa
fix: replace ``label-`` with ``seg-`` where applies
oesteban c05146c
enh: update schema according to this proposal
oesteban f221ad0
fix: folder -> directory (pacify pre-commit)
oesteban 9ec94cd
fix: order of ``scale-`` in the schema
oesteban 1a258b5
enh: refine atlas' definition in common principles
oesteban 79f1ea9
enh: add "authoritative definition of spaces" to template
oesteban 3f2bde5
enh: update schema to consider ``tpl-`` and ``cohort-``
oesteban 95a85a1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 0d7f965
enh(schema): add ``atlas`` to entities
oesteban a9fa24a
fix: delete photo from atlas' file rules
oesteban 44c3ad8
Update src/schema/objects/columns.yaml
oesteban b66c3ee
fix: dereference twice schema files
oesteban c3b6f41
fix: add missing properties to atlas entity definition
oesteban 891bcf0
FIX: update PET examples
mnoergaard 3c517b2
Merge remote-tracking branch 'upstream/master' into bep038
effigies ef1817b
Merge remote-tracking branch 'upstream/bep038' into bep038-review
effigies bc6b064
schema: Move templates out of rules.files
effigies 226f134
test: Fix check to avoid overlap between common_principles and common
effigies ac745e6
schema: Update metaschema, fix errors caught by metaschema
effigies 4cd7f1d
Revert "FIX: update PET examples"
oesteban ee708fd
Merge remote-tracking branch 'upstream/master' into bep038-review
oesteban b527298
Merge remote-tracking branch 'upstream/master' into bep038
effigies be32035
Merge branch 'bep038' into bep038-review
effigies b0775ac
enh: deep refactor after March 11 meeting
oesteban 595ff58
Merge branch 'bep038-review' of github.com:oesteban/bids-specificatio…
oesteban 6ac57c1
fix: typos
oesteban e67df38
fix: sloppy merge
oesteban dc84d11
enh: cleanup before merging cc @effigies
oesteban 3639a41
enh: add ``SampleSize`` as required atlas description metadata
oesteban 045a4cb
enh: add one more subsection to atlas
oesteban d615e66
fix: pacify codespell + links to entities (rather than glossary)
oesteban 0ec4649
Merge pull request #1856 from oesteban/bep038-review
effigies 4722c22
Merge remote-tracking branch 'upstream/master' into bep038
effigies 2266fb7
fix: Latin phrases
effigies 01160d9
sty: remark complaints
effigies 64c7179
Update src/schema/objects/common_principles.yaml
effigies 1937b5d
Update src/schema/objects/common_principles.yaml
effigies 6be8664
Update src/schema/objects/common_principles.yaml
effigies 819ea5f
Apply suggestions from code review
effigies 390885b
Merge remote-tracking branch 'upstream/master' into bep038
effigies 393707e
sty: Address yamllint errors
effigies 598c64c
Apply suggestions from code review
effigies 58dec06
Update src/schema/rules/tabular_data/derivatives/common_derivatives.yaml
effigies 2176709
Apply suggestions from code review
effigies 265cc91
feat: Update definitions of cohort and atlas entities
effigies 9438c09
Apply suggestions from code review
effigies a5e3857
Make tpl/cohort to sub/ses analogy in a note
effigies 7f757d9
Add statement to preface examples
effigies f6f29a3
fix: TSV spacing
effigies 71bfe0e
Remove unenforceable recommendation
effigies e3541f4
Cleanup suggestions from @pwighton
effigies 0298a6e
Merge remote-tracking branch 'upstream/master' into bep038
effigies b8c29ac
schema: Allow template directories
effigies ddae920
schema: Define atlas-*_description.json files
effigies 442022a
feat(schema): Add meta.templates
effigies ec4c6ac
fix(test): Replace removed schema location
effigies 735115a
feat(schema): Move more imaging data into imaging.yaml
effigies 651cf87
feat(schema): Remove redundant anatomical derivative rules
effigies 64d16fe
feat(schema): Expand use of raw templates
effigies 723c265
rf: Dereference while looking up references
effigies c8cc8af
Merge branch 'multiref' into bep038
effigies a017a1e
rf(schema): Move atlas definitions into derivatives
effigies 9a8dd63
Add description suffix
effigies 2bb65c1
Merge remote-tracking branch 'upstream/master' into bep038
effigies 3ba6693
Merge remote-tracking branch 'upstream/bep038' into bep38-schema-refa…
effigies e5e0c07
Merge pull request #2145 from effigies/bep38-schema-refactor
effigies aa50928
Apply suggestions from code review
effigies f830888
Update tools/schemacode/src/bidsschematools/schema.py
effigies 7af68de
Apply suggestions from code review
effigies f6b62f5
Merge remote-tracking branch 'upstream/master' into bep038
effigies 2afe0b0
Merge commit 'dd1e5d23' into bep038
effigies 6ff150d
Merge commit '6d002b21' into bep038
effigies 4262905
Merge remote-tracking branch 'upstream/master' into bep038
effigies 84bd2e5
fix: Drop cohort from non-atlas derivatives
effigies 0c6e99c
fix: Move atlas description to the top of the dataset
effigies b2ffc8e
schema: Add atlas description association
effigies afeb393
Apply suggestions from code review
effigies 8a07810
Update src/schema/rules/files/deriv/imaging.yaml
effigies e3bc354
feat: Validate presence of associated atlas-<label>_description.json
effigies 2764ece
Add recommendation for non-template atlas descriptions
effigies 6de3e40
Set atlas description contents
effigies ac7ad10
Move atlas descriptions to dataset root
effigies 61c08c9
Update text and example headings
effigies 3be49c3
Simplify templates, remove single-subject
effigies 3917225
Clarify scope of xfm warning, render atlas definition
effigies 0c36a54
Remove surface-space atlas examples
effigies e18e4bc
Remove PS13 example
effigies ebb91b3
Remove SpatialReference from example atlas descriptions, clarify requ…
effigies 5b223cd
Allow tpl/space to be standard
effigies 120d7a4
Fix spaces, more updates
effigies 96492c2
Add RRID metadata to match example
effigies d9c9a50
Remove references to probseg/mask.tsv
effigies a9f73ba
schema: Fix nlin6asym capitals, make tpl valid space source
effigies b7af093
schema: Deduplicate atlas description specs
effigies f0b8c4d
fix: Use correct schema path
effigies d088e6d
chore: Update metaschema
effigies b67ac34
Merge remote-tracking branch 'upstream/master' into bep038
effigies 932cf69
Merge branch 'master' into bep038
effigies 6caad0e
Bump
effigies d4f0a33
Update src/derivatives/atlas.md
effigies f56ebb1
Update src/derivatives/atlas.md
effigies df5f710
Update src/derivatives/imaging.md
effigies File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.